New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Remove deprecated version support 2020-07-01 #13611
tools: Remove deprecated version support 2020-07-01 #13611
Conversation
+@jamiesnape for feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: LGTM missing from assignee jamiesnape, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)
CMakeLists.txt, line 111 at r1 (raw file):
# The minimum compiler versions should match those listed in both # doc/developers.rst and tools/workspace/cc/repository.bzl. # TODO(jwnimmer-tri) On 2020-07-01 update GCC min to 7.5 here and in the bzl.
BTW Remove TODO?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape)
CMakeLists.txt, line 111 at r1 (raw file):
Previously, jamiesnape (Jamie Snape) wrote…
BTW Remove TODO?
Done.
+@rpoyner-tri for platform review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber stamp platform review (thanks, Rico!)
Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)
d269630
to
81026ab
Compare
81026ab
to
fbfff80
Compare
This change is