Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Remove deprecated version support 2020-07-01 #13611

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jun 30, 2020

This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator Author

+@jamiesnape for feature review, please.

Copy link
Contributor

@jamiesnape jamiesnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: LGTM missing from assignee jamiesnape, needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge" (waiting on @jamiesnape)


CMakeLists.txt, line 111 at r1 (raw file):

# The minimum compiler versions should match those listed in both
# doc/developers.rst and tools/workspace/cc/repository.bzl.
# TODO(jwnimmer-tri) On 2020-07-01 update GCC min to 7.5 here and in the bzl.

BTW Remove TODO?

Copy link
Contributor

@jamiesnape jamiesnape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge"

Copy link
Collaborator Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits) (waiting on @jamiesnape)


CMakeLists.txt, line 111 at r1 (raw file):

Previously, jamiesnape (Jamie Snape) wrote…

BTW Remove TODO?

Done.

@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for platform review, please.

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp platform review :lgtm: (thanks, Rico!)

Reviewed 2 of 3 files at r1, 1 of 1 files at r2.
Reviewable status: needs platform reviewer assigned, labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

@sherm1 sherm1 self-assigned this Jun 30, 2020
Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@sherm1

Reviewable status: labeled "do not merge", commits need curation (https://drake.mit.edu/reviewable.html#curated-commits)

@jwnimmer-tri jwnimmer-tri merged commit 21a24e5 into RobotLocomotion:master Jul 1, 2020
@jwnimmer-tri jwnimmer-tri deleted the deprecation-2020-07-build branch July 1, 2020 11:35
@jamiesnape jamiesnape removed their assignment Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants