-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multibodyplant: tell scenegraph my name when registering as a source #14024
multibodyplant: tell scenegraph my name when registering as a source #14024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@SeanCurtis-TRI for feature review, please.
Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers (waiting on @SeanCurtis-TRI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One caveat -- I think it's worth calling out somewhere in documentation (probably the documentation for RegisterAsSourceForSceneGraph
) that the plant's name will be passed to SceneGraph where it propagates through to other domains (e.g., visualization), therefore, it is highly recommended to give the plant a recognizable name; the default name won't always be convenient.
I also wonder about the utilities that generate the plant/scene graph pair and what those names look like.
Reviewed 1 of 1 files at r1.
Reviewable status: needs at least two assigned reviewers
b8dccf9
to
0afb135
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (Added to the doc).
Those utilities you refer to do explicitly set the names "plant" and "scene_graph". https://github.com/RobotLocomotion/drake/blob/master/multibody/plant/multibody_plant.cc#L3039
Reviewable status: needs at least two assigned reviewers (waiting on @SeanCurtis-TRI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: needs at least two assigned reviewers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@rpoyner-tri for platform review, please; per the schedule.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform) (waiting on @rpoyner-tri)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),SeanCurtis-TRI(platform)
As discussed with @gizatt and @SeanCurtis-TRI in #13971. The change does seem painless, and only an improvement.
This change is