Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multibodyplant: tell scenegraph my name when registering as a source #14024

Merged

Conversation

RussTedrake
Copy link
Contributor

@RussTedrake RussTedrake commented Sep 6, 2020

As discussed with @gizatt and @SeanCurtis-TRI in #13971. The change does seem painless, and only an improvement.


This change is Reviewable

Copy link
Contributor Author

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@SeanCurtis-TRI for feature review, please.

Reviewable status: LGTM missing from assignee SeanCurtis-TRI(platform), needs at least two assigned reviewers (waiting on @SeanCurtis-TRI)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

One caveat -- I think it's worth calling out somewhere in documentation (probably the documentation for RegisterAsSourceForSceneGraph) that the plant's name will be passed to SceneGraph where it propagates through to other domains (e.g., visualization), therefore, it is highly recommended to give the plant a recognizable name; the default name won't always be convenient.

I also wonder about the utilities that generate the plant/scene graph pair and what those names look like.

Reviewed 1 of 1 files at r1.
Reviewable status: needs at least two assigned reviewers

Copy link
Contributor Author

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (Added to the doc).

Those utilities you refer to do explicitly set the names "plant" and "scene_graph". https://github.com/RobotLocomotion/drake/blob/master/multibody/plant/multibody_plant.cc#L3039

Reviewable status: needs at least two assigned reviewers (waiting on @SeanCurtis-TRI)

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: needs at least two assigned reviewers

Copy link
Contributor Author

@RussTedrake RussTedrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@rpoyner-tri for platform review, please; per the schedule.

Reviewable status: LGTM missing from assignee rpoyner-tri(platform) (waiting on @rpoyner-tri)

Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),SeanCurtis-TRI(platform)

@rpoyner-tri rpoyner-tri merged commit 5f553f5 into RobotLocomotion:master Sep 8, 2020
@RussTedrake RussTedrake deleted the mbp_scenegraph_sourcename branch June 14, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants