trajectories: Adds PiecewisePolynomial::AppendFirstOrderSegment #14030
Conversation
There was a problem hiding this comment.
+@hongkai-dai for feature review
Reviewable status: LGTM missing from assignee hongkai-dai, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on @hongkai-dai)
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers
There was a problem hiding this comment.
+@jwnimmer-tri 
Reviewed 5 of 5 files at r1.
Reviewable status: 1 unresolved discussion (waiting on @RussTedrake)
common/trajectories/piecewise_polynomial.cc, line 361 at r1 (raw file):
} } polynomials_.push_back(matrix);
nit If I'm reading this correctly, I think we want std::move(matrix) here to avoid re-copying all of the Polynomials.
for incremental construction of first-order polynomial trajectories.
RussTedrake
force-pushed
the
pp_append
branch
from
266dc00
to
a342c1e
Compare
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees jwnimmer-tri(platform),hongkai-dai (waiting on @hongkai-dai and @jwnimmer-tri)
common/trajectories/piecewise_polynomial.cc, line 361 at r1 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
nit If I'm reading this correctly, I think we want
std::move(matrix)here to avoid re-copying all of thePolynomials.
Done. (here an in the identical usage above). thanks.
for incremental construction of first-order polynomial trajectories.
This change is