Restore "workspace: Update pybind11 fork to latest commit" #14048
Conversation
This reverts commit 690a7ea.
EricCousineau-TRI
added
the
status: single reviewer ok
There was a problem hiding this comment.
+@jamiesnape for both reviews, please
+(status: single reviewer ok)
Reviewable status: LGTM missing from assignee jamiesnape, needs platform reviewer assigned (waiting on @jamiesnape)
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jamiesnape, needs platform reviewer assigned (waiting on @EricCousineau-TRI and @jamiesnape)
a discussion (no related file):
Working: Should merge once drake-external-examples PR merges first.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned (waiting on @EricCousineau-TRI)
|
If the required fix is to downstream code, then please add release notes text into this commit message to warn users about the breaking change. |
|
Good point - will do. Thanks! |
There was a problem hiding this comment.
Self-assigning platform (I think this works?): +@EricCousineau-TRI
Reviewable status:
complete! all discussions resolved, LGTM from assignees EricCousineau-TRI(platform),jamiesnape
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: Should merge once drake-external-examples PR merges first.
Done.
|
Apologize if I misunderstood. I thought @jwnimmer-tri suggested that @EricCousineau-TRI added a warning into commit message, but I do not see it in GitHub commit. It looks like this: I'm sorry if I wasn't look at the right place. |
|
Ah, sorry Damrong! I had thought that we copied the existing overview text, but forgot that we did not and pushed the Squash-and-merge button too fast. For simplicity, I can add a minor no-op commit that incorporates this text, if it makes it easier for commit analysis for release notes? |
|
In general, for release note amendments other than the commit message, you can either:
I'll add the PR overview text into the notes momentarily, though. |
|
Awesome, thanks! |
Downstream Warning:
If you are using CMake to consume
pydrakeand you compile your own bindings usingpybind11_add_module, you must now reset your target's default visibility to "default" (not "hidden").See drake_cmake_installed for an example of doing so.
This reverts commit 690a7ea.
Resolves #14047
This change is