Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace: Upgrade buildifier to latest release 3.5.0 #14152

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 1, 2020

This change is Reviewable

@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review October 1, 2020 18:14
@jwnimmer-tri
Copy link
Collaborator Author

jwnimmer-tri commented Oct 1, 2020

Tested locally on macsim with bazel test --config lint //....

+@SeanCurtis-TRI for both reviews per schedule, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform)

@jwnimmer-tri jwnimmer-tri merged commit 250cd33 into RobotLocomotion:master Oct 1, 2020
@jwnimmer-tri jwnimmer-tri deleted the new-release-buildifier branch October 1, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: build system Bazel, CMake, dependencies, memory checkers, linters priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants