Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py geometry_test: Fix existing flake8 defects #14233

Merged
merged 1 commit into from Oct 23, 2020
Merged

py geometry_test: Fix existing flake8 defects #14233

merged 1 commit into from Oct 23, 2020

Conversation

EricCousineau-TRI
Copy link
Contributor

@EricCousineau-TRI EricCousineau-TRI commented Oct 21, 2020 •
edited by jwnimmer-tri

Came across during #13835

This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html labels Oct 23, 2020
@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Oct 23, 2020 •
edited by sherm1

+@jwnimmer-tri both reviews :lgtm:, but this needs a rebase.

@jwnimmer-tri jwnimmer-tri self-assigned this Oct 23, 2020
@EricCousineau-TRI
Copy link
Contributor Author

Thanks! Confirmed it looks good:

$ git log -n 1 --oneline --no-decorate
f3a11e23d2 py geometry_test: Fix existing flake8 defects
$ flake8 --select F bindings/pydrake/test/geometry_test.py && echo $?
0

jwnimmer-tri
jwnimmer-tri reviewed Oct 23, 2020
View reviewed changes
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform)

@jwnimmer-tri jwnimmer-tri merged commit 2144375 into RobotLocomotion:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwnimmer-tri jwnimmer-tri jwnimmer-tri left review comments

Assignees

@jwnimmer-tri jwnimmer-tri

Labels
priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EricCousineau-TRI @jwnimmer-tri