Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

workspace: Upgrade ignition_math to latest release 6.8.0 #14848

Merged
merged 1 commit into from Apr 6, 2021
Merged

workspace: Upgrade ignition_math to latest release 6.8.0 #14848

merged 1 commit into from Apr 6, 2021

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Apr 1, 2021 •
edited by sherm1

This change is Reviewable

@jwnimmer-tri jwnimmer-tri mentioned this pull request Apr 1, 2021
Merged
@jwnimmer-tri jwnimmer-tri added priority: low status: single reviewer ok https://drake.mit.edu/reviewable.html labels Apr 1, 2021
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review April 1, 2021 15:09
@jwnimmer-tri
Copy link
Collaborator Author

+@SeanCurtis-TRI for both reviews on Monday, please.

SeanCurtis-TRI
SeanCurtis-TRI reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have expected that this went through a mac build already (as per https://drake.mit.edu/code_review_checklist.html).

:LGTM:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

The OSRC code, especially minor releases, have historically been low risk so I sometimes skip them -- but since I'm not in a hurry, we can check anyway:

@drake-jenkins-bot mac-catalina-clang-bazel-experimental-release please

SeanCurtis-TRI
SeanCurtis-TRI reviewed Apr 5, 2021
View reviewed changes
Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI(platform) (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit a01105a into RobotLocomotion:master Apr 6, 2021
@jwnimmer-tri jwnimmer-tri deleted the new-release-ignition_math branch April 6, 2021 00:35
@EricCousineau-TRI EricCousineau-TRI mentioned this pull request Apr 8, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanCurtis-TRI SeanCurtis-TRI SeanCurtis-TRI left review comments

Assignees

@SeanCurtis-TRI SeanCurtis-TRI

Labels
priority: medium status: single reviewer ok https://drake.mit.edu/reviewable.html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jwnimmer-tri @SeanCurtis-TRI