Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yaml] Clarify unit test for node move operations #15910

Merged

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Oct 12, 2021

Amends #15865 towards #15868.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low release notes: none This pull request should not be mentioned in the release notes labels Oct 12, 2021
@jwnimmer-tri
Copy link
Collaborator Author

+@DamrongGuoy for feature review please, as an amendment on #15865.
+@sherm1 for platform review per schedule, please.

Copy link
Member

@sherm1 sherm1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform :lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee DamrongGuoy (waiting on @DamrongGuoy)

Copy link
Contributor

@DamrongGuoy DamrongGuoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Thanks! These unit tests are very instructive.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignees sherm1(platform),DamrongGuoy (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit 10c4528 into RobotLocomotion:master Oct 12, 2021
@jwnimmer-tri jwnimmer-tri deleted the yaml-node-move-tests branch October 12, 2021 19:05
kunimatsu-tri pushed a commit to kunimatsu-tri/drake that referenced this pull request Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: none This pull request should not be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants