Upgrade externals to latest releases (Feb 2022) #16484
Conversation
BetsyMcPhail
added
the
status: commits are properly curated
BetsyMcPhail
force-pushed
the
upgrades
branch
2 times, most recently
from
7778295
to
0ed0e08
Compare
|
Looks like |
There was a problem hiding this comment.
Is this ready for feature review?
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers, when planning a "properly curated" merge commit the PR must always be rebased onto latest master, missing label for release notes
BetsyMcPhail
force-pushed
the
upgrades
branch
from
0ed0e08
to
f362cb2
Compare
There was a problem hiding this comment.
CI is happy so we're ready for review. +@jwnimmer-tri for feature review please
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, when planning a "properly curated" merge commit the PR must always be rebased onto latest master, missing label for release notes (waiting on @jwnimmer-tri)
jwnimmer-tri
added
the
status: single reviewer ok
There was a problem hiding this comment.
+(status: single reviewer ok) LGTM so far.
Once the next change is pushed, please also launch a macOS CI build. Then we should be OK to merge.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 2 of 2 files at r4, 2 of 2 files at r5, 1 of 1 files at r6, 1 of 1 files at r7, 1 of 1 files at r8, 1 of 1 files at r9, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), when planning a "properly curated" merge commit the PR must always be rebased onto latest master, missing label for release notes (waiting on @BetsyMcPhail)
solvers/scs_solver.cc, line 729 at r9 (raw file):
// their instantiated members) upon return from the DoSolve function. ScopeExit scs_free_guard([&cone, &scs_problem_data, &scs_stgs]() { _scs_free_data(scs_problem_data, cone, scs_stgs);
These changes are curated into the Xacro commit. They should be part of the SCS commit, instead.
BetsyMcPhail
force-pushed
the
upgrades
branch
from
f362cb2
to
fd1e7cb
Compare
|
@drake-jenkins-bot mac-monterey-clang-bazel-experimental-release please |
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee jwnimmer-tri(platform), missing label for release notes (waiting on @jwnimmer-tri)
solvers/scs_solver.cc, line 729 at r9 (raw file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
These changes are curated into the Xacro commit. They should be part of the SCS commit, instead.
Good catch - thanks
There was a problem hiding this comment.
Both macOS builds have passed, so the only thing remaining on this PR is to play the rebase game to reach the tip of master before merging.
Reviewed all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master, missing label for release notes (waiting on @BetsyMcPhail)
BetsyMcPhail
force-pushed
the
upgrades
branch
from
fd1e7cb
to
6bdf87a
Compare
jwnimmer-tri
added
the
release notes: fix
There was a problem hiding this comment.
Rebase is done... I don't have permissions to force merge without waiting for tests
Reviewable status:
complete! all discussions resolved, LGTM from assignee jwnimmer-tri(platform), base commit is latest master (waiting on @BetsyMcPhail)
|
I'll force the merge as soon as one of the bazel builds passes. |
Working towards #16481
The changes to scs are from the PR Under the hood API refactoring. Specifically, see glbopts.h
This change is