[doc] Bump Bazel minimum version to 5.1 #20263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
rpoyner-tri
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform)
This was already true in practice; our docs just missed it.
jwnimmer-tri
force-pushed
the
bazel-min-510
branch
from
0e4a961
to
d1166c1
Compare
rpoyner-tri
reviewed
Sep 30, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee rpoyner-tri(platform)
WawasCode
pushed a commit
to WawasCode/drake
that referenced
this pull request
Oct 31, 2023
This was already true in practice; our docs just missed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was already true in practice; our docs just missed it. The
@vtk_internalrules use bazelbuild/bazel#14835.Amends #19945.
+@rpoyner-tri for both reviews, please.
This change is