Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add z1 arm from Unitree #20284

Closed
wants to merge 3 commits into from
Closed

Conversation

siilats
Copy link

@siilats siilats commented Sep 29, 2023

Original robot files are here
https://github.com/unitreerobotics/z1_ros


This change is Reviewable

@jwnimmer-tri
Copy link
Collaborator

Hi @siilats, thanks for your interest in Drake!

I'd like to understand the plan here, to save you some time in case we're on the wrong track. Please see https://drake.mit.edu/model_version_control.html:

Before you decide to submit models, please ensure that you have tests that will need them. Do not submit a PR that adds models but has zero intent to use them, as Drake is not a model repository.

Our policy is that we only put model files directly into drake or drake_models when those models will be used by Drake's built-in tutorials or examples. For models not directly used by Drake itself, we ask users to keep their own model repositories, separate from Drake.

Do you know if there are any plans to use this new z1 model in future Drake pull requests?

FYI For loading non-Drake model packages, Drake can use ROS_PACKAGE_PATH to load models via PackageMap.PopulateFromRosPackagePath(), or Drake can download packages from remote servers using PackageMap.AddRemote(), or you can add path entries directly to PackageMap with other of its API.

@siilats
Copy link
Author

siilats commented Sep 30, 2023

model files directly into drake or drake_models when those models will be used by Drake's built-in tutorials or examples. For models not directly used by Drake itself, we ask users to keep their own model repositories, separate from Drake.

Hi I have the actual Z1 arm and I am teaching it how to fly a business jet. You can see a bit more in the patent
https://patentsgazette.uspto.gov/week39/OG/html/1514-4/US11767099-20230926.html
Basically I realized I need impedance control in order to push buttons, I also have some cool research stuff on dynamic time warping to align several demonstrations. I will implement them in drake, I started with Peter Corkes and CoppeliaSim but I need better control algorithms.

Also the Z1 is under $10k, its similar to xArm so its a pretty cool research tool.

@jwnimmer-tri
Copy link
Collaborator

jwnimmer-tri commented Oct 3, 2023

That sounds exciting, but I wasn't able to understand whether it directly answers my question?

The question is whether you are planning to contribute a new Drake tutorial file to drake/tutorials that demonstrates something which requires Z1 arm model file -- or something along those lines. Unless and until Drake has tutorial (or example, demo, regression test, etc.) code that needs the Z1 model files, we would not accept a pull request that adds the Z1 model to Drake. (As the document says, "Drake is not a model repository." The only reason we directly incorporate model files as first-party content is when it's a necessary condition to write a good tutorial.)

Possibly if you could share more of your plans for contributing, we'd be able to give better advice & help with the pull requests.

Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @siilats)

@jwnimmer-tri
Copy link
Collaborator

Closing for lack of response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants