-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add z1 arm from Unitree #20284
WIP: Add z1 arm from Unitree #20284
Conversation
Hi @siilats, thanks for your interest in Drake! I'd like to understand the plan here, to save you some time in case we're on the wrong track. Please see https://drake.mit.edu/model_version_control.html:
Our policy is that we only put model files directly into Do you know if there are any plans to use this new z1 model in future Drake pull requests? FYI For loading non-Drake model packages, Drake can use |
Hi I have the actual Z1 arm and I am teaching it how to fly a business jet. You can see a bit more in the patent Also the Z1 is under $10k, its similar to xArm so its a pretty cool research tool. |
That sounds exciting, but I wasn't able to understand whether it directly answers my question? The question is whether you are planning to contribute a new Drake tutorial file to drake/tutorials that demonstrates something which requires Z1 arm model file -- or something along those lines. Unless and until Drake has tutorial (or example, demo, regression test, etc.) code that needs the Z1 model files, we would not accept a pull request that adds the Z1 model to Drake. (As the document says, "Drake is not a model repository." The only reason we directly incorporate model files as first-party content is when it's a necessary condition to write a good tutorial.) Possibly if you could share more of your plans for contributing, we'd be able to give better advice & help with the pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: LGTM missing from assignee jwnimmer-tri(platform), needs at least two assigned reviewers, commits need curation (https://drake.mit.edu/reviewable.html#curated-commits), missing label for release notes (waiting on @siilats)
Closing for lack of response. |
Original robot files are here
https://github.com/unitreerobotics/z1_ros
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)