Remove deprecated code 2024-02 #20846
Conversation
jwnimmer-tri
added
priority: low
release notes: removal of deprecated
There was a problem hiding this comment.
+@hongkai-dai for feature review of changes to inverse_kinematics and solvers and their python bindings, please.
+@sherm1 for feature review of the balance and platform review overall, please.
Reviewable status: 1 unresolved discussion, LGTM missing from assignees hongkai-dai,sherm1(platform)
a discussion (no related file):
Working
Do not merge until 2024-02-01 UTC.
There was a problem hiding this comment.
Wow! That's got to be record for amount of deprecated code nuked. RIP event dispatcher override! Great to see that finally history -- what a horror show.
Platform 
Reviewed 83 of 83 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee hongkai-dai
|
@hongkai-dai will you have time to look over this? |
jwnimmer-tri
force-pushed
the
deprecation-2024-02
branch
from
1ea02de
to
726fcc5
Compare
|
(Re-pushed to avoid a merge conflict with #20872.) |
Most of the removals are the past 3-4 months, but some MbT stuff dates back to 2020 but was overlooked previously.
jwnimmer-tri
force-pushed
the
deprecation-2024-02
branch
from
726fcc5
to
ed7102c
Compare
There was a problem hiding this comment.
-@hongkai-dai won't have time for this. @sherm1 are you okay as single reviewer?
I took another careful look over the solvers and IK changes, and pushed one fix. I think it's ready to merge.
Reviewed 15 of 83 files at r1.
Reviewable status: needs at least two assigned reviewers
There was a problem hiding this comment.
+(status: single reviewer ok)
I looked at inverse_kinematics & solver removals,
Reviewed 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee sherm1(platform)
Most of the removals are the past 3-4 months, but some MbT stuff dates back to 2020 but was overlooked previously.
This change is