-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pydrake doc: Use constexpr auto&
for nesting aliases
#9606
pydrake doc: Use constexpr auto&
for nesting aliases
#9606
Conversation
@drake-jenkins-bot mac-highsierra-clang-bazel-experimental please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@jamiesnape for review, please.
Reviewable status: all discussions resolved, platform LGTM missing
Can you unwind the workarounds here? drake/bindings/pydrake/multibody/rigid_body_tree_py.cc Lines 261 to 414 in d3c9db3
|
2d22a7f
to
d22763c
Compare
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 36 of 36 files at r1.
Reviewable status: all discussions resolved, platform LGTM missing
+@jwnimmer-tri for platform review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 36 of 36 files at r1.
Reviewable status:complete! all discussions resolved, platform LGTM from [jwnimmer-tri]
Resolves #9600
\cc @m-chaturvedi
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)