Validate and remap the topic name for publishers/subscriptions #1177
+149
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces topic name validation and remapping for publisher and subscription endpoints.
- Updated test cases in test/test-graph.js to verify topic remapping under a namespace.
- Added a new C++ binding function in src/rcl_node_bindings.cpp to support topic remapping with proper memory management.
- Enhanced the Node class in lib/node.js to validate and remap topic names before retrieving publisher/subscription info.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test-graph.js | Updated tests to incorporate namespace and remapping verification. |
| src/rcl_node_bindings.cpp | Added RemapTopicName function with proper error handling and cleanup. |
| lib/node.js | Modified Node methods to validate and remap topic names; added helper function. |
Comments suppressed due to low confidence (1)
lib/node.js:1088
- The documentation comment contradicts the implemented behavior where the topic is validated and remapped. Please update the comment to accurately reflect that the topic name is validated and remapped when noDemangle is false.
* The queried `topic` is not remapped.
minggangw
added a commit
that referenced
this pull request
Jun 23, 2025
This PR introduces topic name validation and remapping for publisher and subscription endpoints. - Updated test cases in test/test-graph.js to verify topic remapping under a namespace. - Added a new C++ binding function in src/rcl_node_bindings.cpp to support topic remapping with proper memory management. - Enhanced the Node class in lib/node.js to validate and remap topic names before retrieving publisher/subscription info. Fix: #1176
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces topic name validation and remapping for publisher and subscription endpoints.
Fix: #1176