Add a car demo for electron #1215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a comprehensive car control demonstration for the rclnodejs Electron integration, showcasing how to create interactive ROS2 applications with a web-based UI. The demo features a virtual joystick for controlling a car through ROS2 velocity commands and includes real-time visualization of the car's movement.
Key Changes
- Creates a complete car control demo with joystick interface and car visualization
- Adds comprehensive documentation with setup instructions and technical details
- Includes keyboard and mouse control support with real-time status feedback
- Fixes minor style inconsistencies in the existing topics demo
Reviewed Changes
Copilot reviewed 7 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| electron_demo/topics/main.js | Adds missing semicolons for consistent code style |
| electron_demo/topics/README.md | Improves documentation formatting and removes trailing whitespace |
| electron_demo/car/main.js | Implements the main Electron process with ROS2 node for car control |
| electron_demo/car/renderer.js | Provides the frontend JavaScript for joystick controls and car visualization |
| electron_demo/car/index.html | Creates the user interface with joystick controls and car display area |
| electron_demo/car/package.json | Defines project dependencies and scripts for the car demo |
| electron_demo/car/README.md | Comprehensive documentation covering setup, usage, and technical details |
Comments suppressed due to low confidence (1)
electron_demo/car/package.json:24
- Electron version ^31.0.0 may not exist. As of January 2025, the latest stable Electron version was in the 20s range. Consider using a verified stable version like "^30.0.0" or check the official Electron releases.
"electron": "^31.0.0"
minggangw
added a commit
that referenced
this pull request
Jul 31, 2025
This PR adds a comprehensive car control demonstration for the rclnodejs Electron integration, showcasing how to create interactive ROS2 applications with a web-based UI. The demo features a virtual joystick for controlling a car through ROS2 velocity commands and includes real-time visualization of the car's movement. ### Key Changes - Creates a complete car control demo with joystick interface and car visualization - Adds comprehensive documentation with setup instructions and technical details - Includes keyboard and mouse control support with real-time status feedback - Fixes minor style inconsistencies in the existing topics demo Fix: #1214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive car control demonstration for the rclnodejs Electron integration, showcasing how to create interactive ROS2 applications with a web-based UI. The demo features a virtual joystick for controlling a car through ROS2 velocity commands and includes real-time visualization of the car's movement.
Key Changes
Fix: #1214