Fix the message template issues #392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using message.dot to generate the JavaScript messages for serialization/deserialization. Through testing, we found two problems: - To calculate the byte size of string, Buffer.byteLength should be used. - If the message has a section of array, we should assign the data of the array to null when its capacity is 0. This patch fixed these problems above. Fix RobotWebTools#391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using message.dot to generate the JavaScript messages for
serialization/deserialization. Through testing, we found two problems:
used.
array to null when its capacity is 0.
This patch fixed these problems above.
Fix #391