Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autobahn support breaks Python 3. #448

Closed
mikepurvis opened this issue Dec 5, 2019 · 1 comment · Fixed by #451
Closed

Autobahn support breaks Python 3. #448

mikepurvis opened this issue Dec 5, 2019 · 1 comment · Fixed by #451

Comments

@mikepurvis
Copy link

mikepurvis commented Dec 5, 2019 •
edited
Loading

As of #426, we get the following error under Python 3:

File ".../lib/python3/dist-packages/rosbridge_server/autobahn_websocket.py", line 180, in onMessage
  self.protocol.incoming(message)
File ".../lib/python3/dist-packages/rosbridge_library/protocol.py", line 120, in incoming
  self.buffer = self.buffer + message_string
builtins.TypeError: Can't convert 'bytes' object to str implicitly

Would be great to have a CI setup that ran tests under Py3 as well as Py2.
@mvollrath
Copy link
Contributor

I'll work on fixing this.

Would be great to have a CI setup that ran tests under Py3 as well as Py2.

Rosbridge uses the industrial_ci script for which Python 3 support is in progress.

mvollrath added a commit that referenced this issue Jan 2, 2020
@mvollrath
Fix Autobahn WebSocket vs. Python 3
54b7390 
Fixes #448
@mvollrath mvollrath mentioned this issue Jan 2, 2020
Merged
jihoonl pushed a commit that referenced this issue Jan 6, 2020
@mvollrath @jihoonl
Fix Autobahn WebSocket vs. Python 3 (#451)
856987e 
Fixes #448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Autobahn WebSocket vs. Python 3 RobotWebTools/rosbridge_suite
2 participants
@mikepurvis @mvollrath