Fixes #418: WebSocketClosedError Spam #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvollrath
requested changes
Jul 31, 2019
Brabalawuka
approved these changes
Aug 1, 2019
mvollrath
approved these changes
Aug 1, 2019
|
Thanks you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#413 added a check for the result of tornados WebSocketHandler.write_message and is throwing WebSocketClosedError if its None.
WebSocketHandler.write_message does return a Future since version 4.3.0. (tornado write_message doc)
I added a check to only raisie the Error when version is >4.3.0, to prevent anyone using a tornado version <4.3.0 to have a WebSockedClosedError for every message (see #418).