Skip to content

fix(react-agent-ros2): replace non-blocking run with blocking to avoid severe ROS 2 degradation #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

fix(react-agent-ros2): replace non-blocking run with blocking to avoid severe ROS 2 degradation #661

merged 1 commit into from
Jul 31, 2025

Conversation

maciejmajek
Copy link
Member

@maciejmajek maciejmajek commented Jul 31, 2025 •
edited by boczekbartek
Loading

Purpose

bugfix

  • issue: ReActAgent example is unable to receive messages on /from_human topic

Proposed Changes

run -> run_and_wait_for_shutdown()

Issues

  • Links to relevant issues

Testing

  • How was it tested, what were the results?

@maciejmajek maciejmajek requested a review from boczekbartek July 31, 2025 14:43
@maciejmajek maciejmajek changed the title fix(react-agent-ros2): non blocking run method causing ROS 2 health issues fix(react-agent-ros2): replace non-blocking run with blocking to avoid severe ROS 2 degradation Jul 31, 2025
@maciejmajek maciejmajek merged commit 7c037ac into main Jul 31, 2025
13 checks passed
@maciejmajek maciejmajek deleted the fix/react-agent-ros2 branch July 31, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boczekbartek boczekbartek boczekbartek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maciejmajek @boczekbartek