[NEW] RocketChatLinkButton Component #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 95cfd98 into 43d489e - view on LGTM.com new alerts:
|
Sing-Li
requested changes
Jan 23, 2022
|
Please revise this PR. Do not keep closing and openning new PRs. Thanks. |
sidmohanty11
force-pushed
the
rc-click-to-chat
branch
from
95cfd98
to
267286e
Compare
sidmohanty11
changed the title
|
@Sing-Li I've added the rocketchatlinkbutton component and kept it independent, please let me know if we need to make some other changes. Thank you |
|
@sidmohanty11 Please resolve the trivial conflict and it will be good-to-merge. Thx |
sidmohanty11
force-pushed
the
rc-click-to-chat
branch
from
267286e
to
f923fe6
Compare
|
Done! @Sing-Li |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new RocketChatLinkButton Component which by default redirects to https://open.rocket.chat
rc_comm_1.mp4