Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Error inserting read-receipts with the new Messages model #28671

Merged
merged 5 commits into from Mar 28, 2023

Conversation

matheusbsilva137
Copy link
Contributor

Proposed changes (including videos or screenshots)

  • Fix the following error when inserting read receipts:
@rocket.chat/meteor:dsv: I20230328-16:36:11.569(-3)? [2023-03-28T19:36:10.798Z] ERROR: Argument "docs" must be an array of documents
@rocket.chat/meteor:dsv: I20230328-16:36:11.569(-3)?     err: {
@rocket.chat/meteor:dsv: I20230328-16:36:11.569(-3)?       "type": "MongoInvalidArgumentError",
@rocket.chat/meteor:dsv: I20230328-16:36:11.569(-3)?       "message": "Argument \"docs\" must be an array of documents",
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?       "stack":
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?           MongoInvalidArgumentError: Argument "docs" must be an array of documents
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?               at new InsertManyOperation (/home/matheus/.meteor/packages/npm-mongo/.4.12.1.1u9ugqv.zpd9++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/mongodb/lib/operations/insert.js:68:19)
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?               at Collection.insertMany (/home/matheus/.meteor/packages/npm-mongo/.4.12.1.1u9ugqv.zpd9++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/mongodb/lib/collection.js:154:78)
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?               at Proxy.insertMany (server/models/raw/BaseRaw.ts:231:19)
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?               at ee/server/lib/message-read-receipt/ReadReceipt.js:108:24
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?               at /home/matheus/.meteor/packages/promise/.0.12.2.bqfx3w.89spp++os+web.browser+web.browser.legacy+web.cordova/npm/node_modules/meteor-promise/fiber_pool.js:43:40
@rocket.chat/meteor:dsv: I20230328-16:36:11.570(-3)?     }

Issue(s)

Introduced in #28653

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Mar 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@d4c57c3). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #28671   +/-   ##
==========================================
  Coverage           ?   43.95%           
==========================================
  Files              ?      740           
  Lines              ?    14369           
  Branches           ?     2232           
==========================================
  Hits               ?     6316           
  Misses             ?     7761           
  Partials           ?      292           
Flag Coverage Δ
e2e 43.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 2916748 into develop Mar 28, 2023
39 checks passed
@kodiakhq kodiakhq bot deleted the regression/insert-read-receipt branch March 28, 2023 21:51
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…/federation-public-room-search-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (186 commits)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  regression: Error inserting read-receipts with the new Messages model (#28671)
  refactor: `LivechatDepartments` - 1/2 (#28664)
  chore: Update Apps-Engine to latest (#28646)
  regression: Room Not Found bg color (#28668)
  refactor: Remove promise.await from apps (#28612)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants