refactor(client): Dead code and spurious exports #28654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #28654 +/- ##
===========================================
+ Coverage 45.02% 45.15% +0.12%
===========================================
Files 753 749 -4
Lines 14661 14533 -128
Branches 2134 2240 +106
===========================================
- Hits 6601 6562 -39
+ Misses 7757 7665 -92
- Partials 303 306 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
tassoevan
force-pushed
the
refactor/client-unused
branch
from
12fa2e6
to
44931c3
Compare
ggazzo
approved these changes
Mar 29, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 30, 2023
…/federation-public-room-search-2 * 'develop' of github.com:RocketChat/Rocket.Chat: (186 commits) fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670) regression: fix apps-engine persistence methods (#28688) chore: Update `codeql` to v2 (#28692) fix: Avoid `useEffect` loop (#28699) refactor: Remove `canned responses` model (#28686) refactor(models): Use Messages Raw model (9/N) (#28693) chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690) i18n: fix sentence in 2fa email modal text (#28683) fix: change default text color in homepage custom content block (#28685) refactor(models): Use Messages Raw model (8/N) (#28678) refactor: move hasAllPermission to hasAllPermissionAsync (#28674) refactor: Feature parity for EE models (#28614) refactor(client): Dead code and spurious exports (#28654) fix(client): Fuselage's icon font reloads too often (#28673) refactor: Subscriptions model - 5 (#28550) regression: Error inserting read-receipts with the new Messages model (#28671) refactor: `LivechatDepartments` - 1/2 (#28664) chore: Update Apps-Engine to latest (#28646) regression: Room Not Found bg color (#28668) refactor: Remove promise.await from apps (#28612) ...
gabriellsh
added a commit
that referenced
this pull request
Mar 30, 2023
…avatarEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (57 commits) refactor(client): `readMessage` events (#28709) refactor: Rooms model 1/2 (#28694) refactor: `LivechatTag` model to raw (#28706) refactor: Promise.await removal - ReadReceipt (#28661) refactor: `AutoComplete` Sanitization (#28666) fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670) regression: fix apps-engine persistence methods (#28688) chore: Update `codeql` to v2 (#28692) fix: Avoid `useEffect` loop (#28699) refactor: Remove `canned responses` model (#28686) refactor(models): Use Messages Raw model (9/N) (#28693) chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690) i18n: fix sentence in 2fa email modal text (#28683) fix: change default text color in homepage custom content block (#28685) refactor(models): Use Messages Raw model (8/N) (#28678) refactor: move hasAllPermission to hasAllPermissionAsync (#28674) refactor: Feature parity for EE models (#28614) refactor(client): Dead code and spurious exports (#28654) fix(client): Fuselage's icon font reloads too often (#28673) refactor: Subscriptions model - 5 (#28550) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
I've got a little help from ts-prune on this one.