Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove canned responses model #28686

Merged
merged 3 commits into from Mar 30, 2023
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 29, 2023

ARCH-936

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman marked this pull request as ready for review March 29, 2023 16:29
@KevLehman KevLehman requested a review from a team as a code owner March 29, 2023 16:29
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #28686 (52343d6) into develop (84b171b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28686      +/-   ##
===========================================
- Coverage    45.16%   45.15%   -0.01%     
===========================================
  Files          749      749              
  Lines        14533    14533              
  Branches      2240     2240              
===========================================
- Hits          6564     6563       -1     
  Misses        7662     7662              
- Partials       307      308       +1     
Flag Coverage Δ
e2e 45.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Mar 29, 2023
@ggazzo ggazzo merged commit fcb2551 into develop Mar 30, 2023
35 checks passed
@ggazzo ggazzo deleted the refactor/canned-responses-ee branch March 30, 2023 00:41
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…/federation-public-room-search-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (186 commits)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  regression: Error inserting read-receipts with the new Messages model (#28671)
  refactor: `LivechatDepartments` - 1/2 (#28664)
  chore: Update Apps-Engine to latest (#28646)
  regression: Room Not Found bg color (#28668)
  refactor: Remove promise.await from apps (#28612)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (75 commits)
  refactor: Use `fetch` instead of `meteor/http` (#28682)
  ci: QASE_REPORT only develop branch
  ci: test qase report (#28569)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (57 commits)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants