Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change default text color in homepage custom content block #28685

Merged
merged 2 commits into from Mar 29, 2023

Conversation

guijun13
Copy link
Contributor

@guijun13 guijun13 commented Mar 29, 2023

Proposed changes (including videos or screenshots)

  • The default text (if there is no content or the admin just adds text without style) color in the homepage custom content block was blue (due to color="info"), but should actually be black

Before:

Screen Shot 2023-03-29 at 12 14 47

After:

Screen Shot 2023-03-29 at 12 47 55

Issue(s)

Steps to test or reproduce

Further comments

@guijun13 guijun13 requested a review from a team as a code owner March 29, 2023 15:47
@yash-rajpal yash-rajpal added stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #28685 (bde0893) into develop (84b171b) will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28685      +/-   ##
===========================================
- Coverage    45.16%   44.71%   -0.46%     
===========================================
  Files          749      730      -19     
  Lines        14533    14206     -327     
  Branches      2240     2233       -7     
===========================================
- Hits          6564     6352     -212     
+ Misses        7662     7546     -116     
- Partials       307      308       +1     
Flag Coverage Δ
e2e 44.69% <ø> (-0.44%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit 069e065 into develop Mar 29, 2023
34 checks passed
@kodiakhq kodiakhq bot deleted the fix/homepage-custom-block-color branch March 29, 2023 17:40
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…/federation-public-room-search-2

* 'develop' of github.com:RocketChat/Rocket.Chat: (186 commits)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  regression: Error inserting read-receipts with the new Messages model (#28671)
  refactor: `LivechatDepartments` - 1/2 (#28664)
  chore: Update Apps-Engine to latest (#28646)
  regression: Room Not Found bg color (#28668)
  refactor: Remove promise.await from apps (#28612)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (75 commits)
  refactor: Use `fetch` instead of `meteor/http` (#28682)
  ci: QASE_REPORT only develop branch
  ci: test qase report (#28569)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (57 commits)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  ...
@sampaiodiego sampaiodiego mentioned this pull request May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants