Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: LivechatTag model to raw #28706

Merged
merged 3 commits into from Mar 30, 2023
Merged

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Mar 30, 2023

ARCH-938
ARCH-937 (including here as it's only remove the js model)

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@KevLehman KevLehman requested a review from a team as a code owner March 30, 2023 14:08
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #28706 (291620b) into develop (69b23f4) will increase coverage by 1.43%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28706      +/-   ##
===========================================
+ Coverage    42.75%   44.19%   +1.43%     
===========================================
  Files          736      726      -10     
  Lines        14446    14175     -271     
  Branches      2222     2238      +16     
===========================================
+ Hits          6177     6265      +88     
+ Misses        7971     7601     -370     
- Partials       298      309      +11     
Flag Coverage Δ
e2e 44.15% <ø> (+1.43%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit 151323a into develop Mar 30, 2023
35 checks passed
@ggazzo ggazzo deleted the refactor/livechat-tag-model branch March 30, 2023 17:29
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (75 commits)
  refactor: Use `fetch` instead of `meteor/http` (#28682)
  ci: QASE_REPORT only develop branch
  ci: test qase report (#28569)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (57 commits)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants