Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: AutoComplete Sanitization #28666

Merged
merged 9 commits into from
Mar 30, 2023
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Mar 28, 2023

Proposed changes (including videos or screenshots)

Fuselage Dependency: #1014

Issue(s)

Steps to test or reproduce

Further comments

@dougfabris dougfabris changed the title refactor: AutoComplete Sanitization refactor: AutoComplete Sanitization Mar 28, 2023
@dougfabris dougfabris marked this pull request as ready for review March 29, 2023 15:48
@dougfabris dougfabris requested review from a team as code owners March 29, 2023 15:48
ggazzo
ggazzo previously approved these changes Mar 29, 2023
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #28666 (d13fbde) into develop (82bae0f) will decrease coverage by 0.99%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28666      +/-   ##
===========================================
- Coverage    45.15%   44.16%   -0.99%     
===========================================
  Files          749      725      -24     
  Lines        14533    14166     -367     
  Branches      2240     2238       -2     
===========================================
- Hits          6562     6257     -305     
+ Misses        7665     7603      -62     
  Partials       306      306              
Flag Coverage Δ
e2e 44.12% <100.00%> (-0.99%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

ggazzo
ggazzo previously approved these changes Mar 30, 2023
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge stat: QA skipped labels Mar 30, 2023
@kodiakhq kodiakhq bot merged commit 8371732 into develop Mar 30, 2023
@kodiakhq kodiakhq bot deleted the chore/autoCompleteRefactor branch March 30, 2023 17:11
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…hideSysMes

* 'develop' of github.com:RocketChat/Rocket.Chat: (75 commits)
  refactor: Use `fetch` instead of `meteor/http` (#28682)
  ci: QASE_REPORT only develop branch
  ci: test qase report (#28569)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  ...
gabriellsh added a commit that referenced this pull request Mar 30, 2023
…avatarEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat: (57 commits)
  refactor(client): `readMessage` events (#28709)
  refactor: Rooms model 1/2 (#28694)
  refactor: `LivechatTag` model to raw (#28706)
  refactor: Promise.await removal - ReadReceipt (#28661)
  refactor: `AutoComplete` Sanitization (#28666)
  fix: Unauthorized Toast Message when accessing a channel's team that user are not a member (#28670)
  regression: fix apps-engine persistence methods (#28688)
  chore: Update `codeql` to v2 (#28692)
  fix: Avoid `useEffect` loop (#28699)
  refactor: Remove `canned responses` model (#28686)
  refactor(models): Use Messages Raw model (9/N) (#28693)
  chore: Delete unused `.../surfaces/SurfaceContext.tsx` (#28690)
  i18n: fix sentence in 2fa email modal text (#28683)
  fix: change default text color in homepage custom content block (#28685)
  refactor(models): Use Messages Raw model (8/N) (#28678)
  refactor: move hasAllPermission to hasAllPermissionAsync (#28674)
  refactor: Feature parity for EE models (#28614)
  refactor(client): Dead code and spurious exports (#28654)
  fix(client): Fuselage's icon font reloads too often (#28673)
  refactor: Subscriptions model - 5 (#28550)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants