-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Required custom field consider blank space as valid input #29635
Conversation
🦋 Changeset detectedLatest commit: 5c46490 The changes in this PR will be included in the next version bump. This PR includes changesets to release 25 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## develop #29635 +/- ##
===========================================
- Coverage 46.68% 46.65% -0.03%
===========================================
Files 692 692
Lines 12926 12926
Branches 2238 2238
===========================================
- Hits 6034 6031 -3
- Misses 6568 6570 +2
- Partials 324 325 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
…custom-field-required-blank-space
Proposed changes (including videos or screenshots)
Adjusted custom fields validation to not accept empty strings on required fields.
Issue(s)
OC-830
Steps to test or reproduce
Further comments