Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wrong sysmessage when resuming chat from on hold #31205

Merged
merged 6 commits into from
Dec 12, 2023

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Dec 11, 2023

OC-1251

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 71d4a1f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #31205 (71d4a1f) into develop (6cf598b) will decrease coverage by 8.98%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31205      +/-   ##
===========================================
- Coverage    57.88%   48.90%   -8.98%     
===========================================
  Files          886     3270    +2384     
  Lines        20290    80305   +60015     
  Branches      3783    16375   +12592     
===========================================
+ Hits         11744    39271   +27527     
- Misses        7845    36386   +28541     
- Partials       701     4648    +3947     
Flag Coverage Δ
e2e 51.44% <ø> (+9.07%) ⬆️
e2e-api 40.65% <0.00%> (?)
unit 66.72% <ø> (-10.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

lmauromb
lmauromb previously approved these changes Dec 11, 2023
@KevLehman KevLehman marked this pull request as ready for review December 11, 2023 20:19
@KevLehman KevLehman requested review from a team as code owners December 11, 2023 20:19
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 11, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 12, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 12, 2023
@kodiakhq kodiakhq bot merged commit faf4121 into develop Dec 12, 2023
44 of 45 checks passed
@kodiakhq kodiakhq bot deleted the fix/wrong-sysmes-resuming-onhold branch December 12, 2023 18:17
@casalsgh casalsgh added this to the 6.6 milestone Dec 13, 2023
gabriellsh added a commit that referenced this pull request Dec 13, 2023
…/emailEmoji

* 'develop' of github.com:RocketChat/Rocket.Chat:
  chore: `Field` normalization (#31182)
  refactor: `Conversations` Overview Analytics (#31217)
  fix: Notifications for thread messages are sent even after thread has been read (#31181)
  ci: remove carryforward from codecov (#31216)
  fix: Wrong sysmessage when resuming chat from on hold (#31205)
  fix: Gallery not working inside threads (#31213)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants