Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toolbox submenu not being displayed in small resolutions #31288

Merged
merged 3 commits into from
Dec 21, 2023

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Dec 20, 2023

Proposed changes (including videos or screenshots)

Issue(s)

SUP-429

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 6974211

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e22d6f0) 48.91% compared to head (6974211) 49.31%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31288      +/-   ##
===========================================
+ Coverage    48.91%   49.31%   +0.39%     
===========================================
  Files         3232     3299      +67     
  Lines        80178    81120     +942     
  Branches     16404    16593     +189     
===========================================
+ Hits         39217    40002     +785     
- Misses       36359    36462     +103     
- Partials      4602     4656      +54     
Flag Coverage Δ
e2e 52.58% <100.00%> (+1.11%) ⬆️
e2e-api 40.62% <ø> (ø)
unit 76.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva marked this pull request as ready for review December 20, 2023 17:23
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner December 20, 2023 17:23
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 21, 2023
@KevLehman KevLehman added stat: needs QA squad: omnichannel and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Dec 21, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Dec 21, 2023
@kodiakhq kodiakhq bot merged commit eee67dc into develop Dec 21, 2023
45 checks passed
@kodiakhq kodiakhq bot deleted the fix/hidden-toolbox-actions branch December 21, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants