New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Prevent Fallback forward departments
feature to go on loop when configured as circular chain
#31328
Conversation
🦋 Changeset detectedLatest commit: 0cbfc7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31328 +/- ##
============================================
- Coverage 59.88% 49.55% -10.34%
============================================
Files 1793 3315 +1522
Lines 34897 81475 +46578
Branches 7263 16736 +9473
============================================
+ Hits 20898 40374 +19476
- Misses 12398 36397 +23999
- Partials 1601 4704 +3103
Flags with carried forward coverage won't be shown. Click here to find out more. |
…Chat into fix/fallback-dep-loop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to add some test cases for the maximum number of depth?
apps/meteor/ee/app/livechat-enterprise/server/hooks/onTransferFailure.ts
Outdated
Show resolved
Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/hooks/onTransferFailure.ts
Outdated
Show resolved
Hide resolved
Tests are definitely possible. The test would take some time however to create the number of departments required for properly testing depth, so at the end I didn't do it 🤔 I can include it on a separate PR too. |
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
SUP-449
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments