feat: Convert emoji shortname to unicode on notification emails. #31225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7695d52 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #31225 +/- ##
===========================================
- Coverage 59.89% 59.85% -0.04%
===========================================
Files 1792 1795 +3
Lines 34898 34933 +35
Branches 7265 7272 +7
===========================================
+ Hits 20901 20910 +9
- Misses 12400 12416 +16
- Partials 1597 1607 +10
Flags with carried forward coverage won't be shown. Click here to find out more. |
pierre-lehnen-rc
previously approved these changes
Dec 13, 2023
…/emailEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: chore: `Field` normalization (#31182) refactor: `Conversations` Overview Analytics (#31217) fix: Notifications for thread messages are sent even after thread has been read (#31181) ci: remove carryforward from codecov (#31216) fix: Wrong sysmessage when resuming chat from on hold (#31205) fix: Gallery not working inside threads (#31213)
…/emailEmoji * 'develop' of github.com:RocketChat/Rocket.Chat: (166 commits) feat: Add `chat.getURLPreview` endpoint (#30478) chore: QoL changes for Omnichannel (#31468) fix: add missing labels to UsersByTimeOfTheDaySection (#31368) refactor: Remove `Notifications` module (#31463) i18n: zh translation error (#21600) feat: `Bubble` on new messages indicators (#31478) test: fix flaky setGuestName test (#31486) Release 6.5.3 chore: RateLimiter to async (#31480) chore: Revert "chore: Add missing changeset file" (#31481) chore: Remove `MessageContentBody` additional styles (#31476) chore: Replace `Notifications` module in favor of `SDK` inside CachedCollection (#31424) chore: improve backend startup (#31479) chore: fix embedded livechat tests (#31477) fix: Department name being double escaped (#31454) chore: Remove unnecessary changeset file (#31472) chore(eslint-config): Include missing ESLint configuration for React (#30977) refactor: Replace `Notifications` module in favor of `sdk` for Omnichannel/WebRTC (#31460) refactor: Replace `Notifications` module in favor of `sdk` for Video Conf (#31462) feat: Add support to cancel editing message action (#31347) ...
tassoevan
approved these changes
Jan 22, 2024
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2024
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits) fix: Marketplace apps installed as private showing as installed (#31514) test: fix messaging flaky test (#31512) fix: change the push sound sent when the push is from video conference (#30910) fix: ensure sessionId on Sessions documents (#31487) chore: handle rocket.cat creation and deletion (#31170) chore(agenda): Changes in Agenda API (#31427) refactor: Pay the debt of some TODO comments (#30338) feat: Room header keyboard navigability (#31516) fix: Cron job for clearing OEmbed cache isn't working (#31336) refactor(client): Handling of custom statuses (#31500) fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328) feat: Add `push.test` endpoint (#31289) chore: split UserProvider into two: User and Authentication (#31513) fix: Can't remove channel's password to join (#31507) chore: convert CAS integration code to typescript (#31492) feat: Composer keyboard navigability (#31510) fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426) feat: Convert emoji shortname to unicode on notification emails. (#31225) chore: Normalize `ButtonGroup` (#31499) chore: improve type definitions for login service configurations (#31491) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Only unicode emoji are supported
Before:
After
Issue(s)
PROD-48
Steps to test or reproduce
Further comments