fix: Can't remove channel's password to join

[Spiral-Memory]

Proposed changes (including videos or screenshots)

The issue arises from a minor detail: when the password box is empty, the condition data.joinCode results in a falsy value. As a result, no key with the name joinCode is sent, preventing the password from unsetting. The backend, however, expects an empty string ('') to unset the password. To resolve this, a small fix was implemented. The getDirtyFields returns a key of joinCodeRequired when the password to access toggle changes. So, i used that property to create a new condition to check for the existence of this key. If it exists, an object named joinCode with an empty string value is created and sent to the backend to address the issue.

Issue(s)

Closes #31506

2024-01-21.21-28-26.mp4

Steps to test or reproduce

The steps to reproduce is mentioned in the issue I created, which is #31506.

Further comments

Just a very small but important fix.

[changeset-bot]

🦋 Changeset detected

Latest commit: b1f03f7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dougfabris]

@Spiral-Memory Nice catch, thank you so much for helping us!

[codecov]

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4ff8bb9) 55.08% compared to head (b1f03f7) 53.24%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31507      +/-   ##
===========================================
- Coverage    55.08%   53.24%   -1.84%     
===========================================
  Files         1537     1575      +38     
  Lines        30324    27063    -3261     
  Branches      6234     5769     -465     
===========================================
- Hits         16704    14411    -2293     
+ Misses       12332    11412     -920     
+ Partials      1288     1240      -48     

Flag	Coverage Δ
e2e	53.22% <0.00%> (+7.92%)	⬆️
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

[Spiral-Memory]

@dougfabris , Thank you so much for reviewing my changes and approving them. It's my very first PR in this repository to get merged, and I am really happy that I could be of some use in helping the application. I would like to request you to please review two more of my PRs: PR #1265 and PR #1262 in the Fuselage repository if possible. They were raised a week before, and I believe they might be helpful as well.

Additionally, I would like to report a security issue in the Rocket Chat application related with password protected channel only. However, I am uncertain whether to report it in the bug section or the security vulnerability section. Could you please guide me on this? Also, can I work on that issue?

[dougfabris]

@Spiral-Memory Sure, I will take a look as soon as possible.
For vulnerability and security issues I would recommend you use our Hackerone page

[Spiral-Memory]

@Spiral-Memory Sure, I will take a look as soon as possible.
For vulnerability and security issues I would recommend you use our Hackerone page

Thank you for your reply. Sir, I have reported the security issue on GitHub in the security vulnerability section. You can have a look; it's still in the triage phase. Also, HackerOne is not accepting submissions, I believe.