Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) #31426

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) #31426

merged 2 commits into from
Jan 22, 2024

Conversation

Devansht420
Copy link
Contributor

Proposed changes (including videos or screenshots)

This PR aims to resolve the issue where a warning related to render function was logged which was -
MessageType.render is deprecated. Use MessageType.message instead.

Before:
image

After:
image

Issue(s)

fixes #28384

Steps to test or reproduce

  1. Start the application
  2. See error in the logs

Further comments

@Devansht420 Devansht420 requested a review from a team as a code owner January 11, 2024 18:15
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: fd6cff1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

KevLehman
KevLehman previously approved these changes Jan 12, 2024
View reviewed changes
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jan 12, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (9217c4f) 49.60% compared to head (fd6cff1) 47.44%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31426      +/-   ##
===========================================
- Coverage    49.60%   47.44%   -2.17%     
===========================================
  Files         3310     1819    -1491     
  Lines        81441    55729   -25712     
  Branches     16699    11162    -5537     
===========================================
- Hits         40400    26439   -13961     
+ Misses       36348    25748   -10600     
+ Partials      4693     3542    -1151
Flag Coverage Δ
e2e ?
e2e-api 40.70% <25.00%> (-0.01%) ⬇️
unit 76.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman
Copy link
Contributor

@Devansht420 , thanks for your contribution :) it was on line to be merged but Prettier failed. Would you mind checking the lint issues and fix them? 🙏🏽

@Devansht420
Copy link
Contributor Author

Sure @KevLehman I'll check the lint issues ASAP and amend the changes.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 16, 2024
@Devansht420
Copy link
Contributor Author

hey @KevLehman , I've fixed the lint issues and tested it, no more errors now.
I think its good to go. 🚀

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Jan 22, 2024
@kodiakhq kodiakhq bot merged commit 6e0f3c1 into RocketChat:develop Jan 22, 2024
40 of 41 checks passed
gabriellsh added a commit that referenced this pull request Jan 23, 2024
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into addDocs
90f6245 
* 'develop' of github.com:RocketChat/Rocket.Chat: (143 commits)
  fix: Marketplace apps installed as private showing as installed (#31514)
  test: fix messaging flaky test (#31512)
  fix: change the push sound sent when the push is from video conference (#30910)
  fix: ensure sessionId on Sessions documents (#31487)
  chore: handle rocket.cat creation and deletion (#31170)
  chore(agenda): Changes in Agenda API (#31427)
  refactor: Pay the debt of some TODO comments (#30338)
  feat: Room header keyboard navigability (#31516)
  fix: Cron job for clearing OEmbed cache isn't working (#31336)
  refactor(client): Handling of custom statuses (#31500)
  fix: Prevent `Fallback forward departments` feature to go on loop when configured as circular chain (#31328)
  feat: Add `push.test` endpoint (#31289)
  chore: split UserProvider into two: User and Authentication (#31513)
  fix: Can't remove channel's password to join (#31507)
  chore: convert CAS integration code to typescript (#31492)
  feat: Composer keyboard navigability (#31510)
  fix: Render warning in Logs - (MessageType.render is deprecated. Use MessageType.message instead) (#31426)
  feat: Convert emoji shortname to unicode on notification emails. (#31225)
  chore: Normalize `ButtonGroup` (#31499)
  chore: improve type definitions for login service configurations (#31491)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevLehman KevLehman KevLehman approved these changes

Assignees
No one assigned
Labels
communityPR squad: omnichannel stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MessageType.render is deprecated. Use MessageType.message instead
2 participants
@Devansht420 @KevLehman