fix: Server sending 2 notifications when @all/@here were used by a user without permissions
#32289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 351545f The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32289 +/- ##
===========================================
+ Coverage 55.48% 55.50% +0.02%
===========================================
Files 2371 2374 +3
Lines 52062 52095 +33
Branches 10651 10657 +6
===========================================
+ Hits 28888 28917 +29
- Misses 20636 20637 +1
- Partials 2538 2541 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Looks like this PR is ready to merge! 🎉 |
MarcosSpessatto
requested changes
Apr 23, 2024
MarcosSpessatto
approved these changes
Apr 23, 2024
dougfabris
approved these changes
Apr 25, 2024
jessicaschelly
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
dionisio-bot
bot
removed
the
stat: ready to merge
KevLehman
added
the
stat: ready to merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rocketchat.atlassian.net/browse/SUP-549
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
A duplicate call to
api.broadcastwas causing that an error onBeforeSavePreventMentionwas being propagated twice to clients.The global handler on
saveMessagewas updated to support using thedetailsproperty coming from meteor errors allowing the original hook to just throw and allow the caller to handle the error accordingly.