-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: Improve permissions check on groups endpoints #32332
chore!: Improve permissions check on groups endpoints #32332
Conversation
Co-authored-by: Diego Sampaio <chinello@gmail.com>
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32332 +/- ##
=================================================
- Coverage 55.74% 55.51% -0.24%
=================================================
Files 2409 2407 -2
Lines 52936 52902 -34
Branches 10875 10866 -9
=================================================
- Hits 29511 29366 -145
- Misses 20812 20923 +111
Partials 2613 2613
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
groups
endpoints by using thepermissionsRequired
property.Issue(s)
CORE-339
Steps to test or reproduce
Further comments
The intention for this PR is to improve code readability and make unauthorized erros more standardized. No side effects are expected. We're considering this a breaking change since unauthorized errors are being changed to follow the same standard when possible.