refactor: combine preprocessor with conformer #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preprocessor and conformer were requiring many of the same attributes. Instead of passing many of the attributes to one another combined the classes. Preprocessor methods are private because they are more complex. Also move some preprocessor functions to transformations
singjc
approved these changes
Jan 24, 2024
|
@irahorecka do you know why this is failing on mac? |
|
Hi - is this still an issue? What's breaking? |
|
I don't think it's an issue now, just had to re-run the test |
sorry yes it was failing before but now it is good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preprocessor and conformer were requiring many of the same attributes. Instead of passing many of the attributes to one another combined the classes. Preprocessor methods are private because they are more complex.
Also move some preprocessor functions to transformations
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested using the GUI
Contents (#101)
Other