Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/plotting #29

Merged
merged 13 commits into from
Nov 15, 2023
Merged

Patch/plotting #29

merged 13 commits into from
Nov 15, 2023

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Nov 9, 2023 •
edited
Loading

  • I added a plotConfig class to GenericPlotter to initialize and store parameters that are used for plotting, instead of passing multiple args
  • I added interactive plotting for chromatograms that utilize the transitionGroup structure, and added future methods for plotting spectra and mobilograms for raw targeted extracted data

@singjc singjc added enhancement New feature or request refactor Refactoring code labels Nov 9, 2023
@singjc singjc requested a review from jcharkow November 9, 2023 20:04
@singjc singjc self-assigned this Nov 9, 2023
jcharkow
jcharkow previously requested changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@jcharkow jcharkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please see my suggestions to reduce repetitive code bits. I would suggest using the newly implemented getLevel() function

massseer/plotting/InteractivePlotter.py Outdated Show resolved Hide resolved
massseer/plotting/InteractivePlotter.py Outdated Show resolved Hide resolved
massseer/plotting/InteractivePlotter.py Outdated Show resolved Hide resolved
massseer/plotting/GenericPlotter.py Show resolved Hide resolved
massseer/plotting/InteractivePlotter.py Outdated Show resolved Hide resolved
massseer/plotting/InteractivePlotter.py Outdated Show resolved Hide resolved
@singjc singjc requested a review from jcharkow November 14, 2023 17:37
@singjc singjc dismissed jcharkow’s stale review November 15, 2023 06:18

Refactored repetitive chrom plotting.

@singjc singjc merged commit 0b81cb7 into patch/masterRefactor Nov 15, 2023
@singjc singjc deleted the patch/plotting branch November 15, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcharkow jcharkow Awaiting requested review from jcharkow

Assignees

@singjc singjc

Labels
enhancement New feature or request refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singjc @jcharkow