Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] performance measurements #57

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Conversation

singjc
Copy link
Collaborator

@singjc singjc commented Dec 22, 2023

Added arg to track and save performance metrics of execution time and RSS memory of code blocks.

@singjc singjc self-assigned this Dec 24, 2023
@singjc singjc added the enhancement New feature or request label Dec 24, 2023
@singjc singjc requested a review from jcharkow December 24, 2023 21:18
Copy link
Collaborator

@jcharkow jcharkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good however I have been playing around with extracted ion chromatogram so there will be conflicts maybe hold off on committing that file?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There will be merge conflicts with this file my raw data maybe hold off on this file temporarily?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcharkow kk, I reverted this file back to the feature/rawdata state. If you haven't already, can you add the caching decorators for osw_data_access and sqmass_loader in this file. I added it to the version before reverting because this saves time from loading it every time an interaction is made. Or I can add it later once the feature/rawdata is merged with your refactoring.

If everything looks good, let me know if this PR can be merged.

    @conditional_decorator(lambda func: st.cache_resource(show_spinner=False)(func), check_streamlit())
    def osw_data_access(_self):
        """
        Loads data from the OSW file.
        """
        osw_data = OSWDataAccess(_self.massseer_gui.file_input_settings.osw_file_path)
        return osw_data
        
    @conditional_decorator(lambda func: st.cache_resource(show_spinner=False)(func), check_streamlit())
    def sqmass_data_loader(_self):
        """
        Loads data from the SqMass file.
        """
        sqmass_data = SqMassLoader(_self.massseer_gui.file_input_settings.sqmass_file_path_list, _self.massseer_gui.file_input_settings.osw_file_path)
        return sqmass_data

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@singjc singjc requested a review from jcharkow December 25, 2023 23:59
@jcharkow
Copy link
Collaborator

yes this PR can be merged

@singjc singjc merged commit eb42579 into feature/rawdata Dec 26, 2023
@singjc singjc deleted the patch/performance_measure branch December 26, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants