-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] performance measurements #57
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good however I have been playing around with extracted ion chromatogram so there will be conflicts maybe hold off on committing that file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There will be merge conflicts with this file my raw data maybe hold off on this file temporarily?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jcharkow kk, I reverted this file back to the feature/rawdata state. If you haven't already, can you add the caching decorators for osw_data_access and sqmass_loader in this file. I added it to the version before reverting because this saves time from loading it every time an interaction is made. Or I can add it later once the feature/rawdata is merged with your refactoring.
If everything looks good, let me know if this PR can be merged.
@conditional_decorator(lambda func: st.cache_resource(show_spinner=False)(func), check_streamlit())
def osw_data_access(_self):
"""
Loads data from the OSW file.
"""
osw_data = OSWDataAccess(_self.massseer_gui.file_input_settings.osw_file_path)
return osw_data
@conditional_decorator(lambda func: st.cache_resource(show_spinner=False)(func), check_streamlit())
def sqmass_data_loader(_self):
"""
Loads data from the SqMass file.
"""
sqmass_data = SqMassLoader(_self.massseer_gui.file_input_settings.sqmass_file_path_list, _self.massseer_gui.file_input_settings.osw_file_path)
return sqmass_data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good
yes this PR can be merged |
Added arg to track and save performance metrics of execution time and RSS memory of code blocks.