-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting Bug fixes and new features #75
Conversation
add option for labels to be added to TransitionGroupFeature plot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I like the legends for the peak boundaries and the normalization of the 2D plots.
I just made a suggestion to make a method for the equalization code and place it in the dataProcessing/transformations.py
file
I think it would be good to add 2D gaussian smoothing to the heatmaps. Maybe @alhigaylan has already done this in a separate branch?
Can be merged when ready.
hist, bins = np.histogram(arr.flatten(), self.config.normalization_dict['bins'], density=True) | ||
cdf = hist.cumsum() # cumulative distribution function | ||
cdf = (self.config.normalization_dict['bins']-1) * cdf / cdf[-1] # normalize | ||
|
||
# use linear interpolation of cdf to find new pixel values | ||
image_equalized = np.interp(arr.flatten(), bins[:-1], cdf) | ||
arr = image_equalized.reshape(arr.shape) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this as a method to the dataProcessing/transformations.py
file?
I was talking with @alhigaylan and he said he did 1D gauss smoothing and not 2D maybe they can be combined once everything is merged. |
Sounds good, we can merge for now, and then integrate once they're all merged together. |
While making figures fixed the following bugs and added these features
Features
Bug fixes