hidden_by_default does not work when name is not set even if all the series have a unique name

[zanna-37]

Checklist

• I updated the card to the latest version available
• I cleared the cache of my browser
• I verified that I'm really running the lastest version in my browser console
• I checked if there is another issue opened with the same problem

Describe the bug
hidden_by_default does not work when name is not set even if all the series have a unique name. It does work if I add the name field. Is this expected behavior? Shouldn't the card pick the entity name?
(and yes, I set the experimental: hidden_by_default: true)

Version of the card
Version: 1.10.0

To Reproduce
This does not hide the series

type: custom:apexcharts-card
apex_config:
  chart:
    height: 500px
experimental:
  hidden_by_default: true
header:
  show: false
  show_states: true
  colorize_states: true
graph_span: 12h
all_series_config:
  group_by:
    func: avg
    duration: 4m
series:
  - entity: sensor.template_ensolar_power_in_house
    extend_to_end: false
    float_precision: 0
    color: '#3498db'
    stroke_width: 4
    yaxis_id: watt
# [...]
  - entity: sensor.template_ensolar_percentage_battery
    show:
      hidden_by_default: true    # <=================
    extend_to_end: false
    float_precision: 0
    color: '#f39c12'
    stroke_width: 3
    yaxis_id: percent
yaxis:
  - id: watt
    decimals: 0
    apex_config:
      forceNiceScale: true
  - id: percent
    decimals: 0
    max: 100
    min: ~50
    apex_config:
      forceNiceScale: true
      floating: true

while this does (notice the added name: a, name: b, ...)

type: custom:apexcharts-card
apex_config:
  chart:
    height: 500px
experimental:
  hidden_by_default: true
header:
  show: false
  show_states: true
  colorize_states: true
graph_span: 12h
all_series_config:
  group_by:
    func: avg
    duration: 4m
series:
  - entity: sensor.template_ensolar_power_in_house
    name: a  # <---------------------------------
    extend_to_end: false
    float_precision: 0
    color: '#3498db'
    stroke_width: 4
    yaxis_id: watt
# [...]
  - entity: sensor.template_ensolar_percentage_battery
    name: e  # <---------------------------------
    show:
      hidden_by_default: true    # <=================
    extend_to_end: false
    float_precision: 0
    color: '#f39c12'
    stroke_width: 3
    yaxis_id: percent
yaxis:
  - id: watt
    decimals: 0
    apex_config:
      forceNiceScale: true
  - id: percent
    decimals: 0
    max: 100
    min: ~50
    apex_config:
      forceNiceScale: true
      floating: true

Screenshots
This doesn't work (first yaml)

This does (second yaml)

Expected behavior
I expect the card to pick the entity name without having to repeat it in the card configuration.

Desktop (please complete the following information):

• Browser chrome
• Version 97.0.4692.71

Smartphone (please complete the following information):

• OS: Android
• Browser chrome
• Version 96.0.4664.45

[RomRider]

That is correct, I have a bug here:

apexcharts-card/src/utils.ts

Line 74 in 4d72937

series[index].name || entities[index]?.attributes?.friendly_name || entities[entities[index]]?.entity_id || '';

:)

I'm going to fix it.

[zanna-37]

Thank you very much! Was it a known issue?

[RomRider]

No, thanks for reporting :)

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[zanna-37]

Still an issue.

[github-actions]

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

[github-actions]

🎉 This issue has been resolved in version 2.0.0-dev.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[zanna-37]

Thanks, I confirm it's working! =)