Change Android mv() back to using the system renameTo() method. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous change to rn-fetch-blob's mv implementation entailed copying the source file to the destination file and then deleting the source file. This approach has an undesirable impact on the mv operation, where the operation takes orders of magnitude longer to complete. It also adds disk space requirements that shouldn't be necessary, since both files need to exist at the same time. This change goes back to using the renameTo() method, while adding some extra error checking to hopefully alleviate whatever problems caused the original fix. Note that the POSIX mv() and rename() methods both stipulate that moving to a non-existent directory should be treated as an error.
|
Can't find the original issue anymore either. |
|
Yes. Our team has been using this code for at least a year. |
|
Thanks for the merges, Ron. I'm happy to help with other issues. Let's talk some time about how I could help. |
|
@pcardon thank you very much for the offer! Feel free to contact me. Best you just send me a mail to dev@ikascripts.de |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous change to rn-fetch-blob's mv implementation entailed copying the source file to the destination file and then deleting the source file. This approach has an undesirable impact on the mv operation, where the operation takes orders of magnitude longer to complete. It also adds disk space requirements that shouldn't be necessary, since both files need to exist at the same time.
This change goes back to using the renameTo() method, while adding some extra error checking to hopefully alleviate whatever problems caused the original fix.
Note that the POSIX mv() and rename() methods both stipulate that moving to a non-existent directory should be treated as an error.