Skip to content

Conversation

pirs1337
Copy link
Contributor

@pirs1337 pirs1337 commented Sep 4, 2025

refs: #38

@pirs1337 pirs1337 self-assigned this Sep 4, 2025
@coveralls
Copy link

coveralls commented Sep 4, 2025

Pull Request Test Coverage Report for Build 17647760690

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 98.864%

Totals Coverage Status
Change from base Build 17570552601: 0.06%
Covered Lines: 261
Relevant Lines: 264

💛 - Coveralls

@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Sep 5, 2025
@DenTray DenTray requested a review from Copilot September 9, 2025 03:26
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a web login feature for the Laravel project initializer by adding authentication scaffolding and UI components.

Key changes:

  • Adds login controller with authentication capabilities
  • Creates Blade templates for login form and app layout
  • Integrates web authentication routes into the initialization process

Reviewed Changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
stubs/controllers/LoginController.php New authentication controller with redirect to telescope
stubs/views/login.blade.php Bootstrap-styled login form template
stubs/views/app.blade.php Base application layout template
src/ProjectInitializatorServiceProvider.php Publisher configuration for web login assets
src/Commands/InitCommand.php Integration of web login publishing into init command
tests/InitCommandTest.php Test coverage for web login feature
tests/TestCase.php Helper method for fixture assertions
tests/fixtures/InitCommandTest/*.php Test fixtures for validation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
];
}

protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void
protected function assertFileEqualsFixture(string $fixture, string $fileName, bool $exportMode = false): void

protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void
{
if ($this->globalExportMode || $exportMode) {
$this->exportJson($fixture, $data);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$this->exportJson($fixture, $data);
$this->exportContent($data, $fixture);

}

$fixturePath = $this->prepareFixtureName($this->getFixturePath($fixture));
$assertFailedMessage = "Failed asserting that the provided data equal to fixture: {$fixturePath}";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$assertFailedMessage = "Failed asserting that the provided data equal to fixture: {$fixturePath}";
$assertFailedMessage = "Failed asserting that the file {$fileName} equal to fixture: {$fixturePath}";

@DenTray DenTray assigned pirs1337 and unassigned DenTray Sep 9, 2025
@pirs1337 pirs1337 assigned DenTray and unassigned pirs1337 Sep 9, 2025
@DenTray DenTray merged commit 7948cd8 into main Sep 11, 2025
3 checks passed
@DenTray DenTray deleted the 38_Add-web-login-feature branch September 11, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants