-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add web login feature #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 17647760690Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a web login feature for the Laravel project initializer by adding authentication scaffolding and UI components.
Key changes:
- Adds login controller with authentication capabilities
- Creates Blade templates for login form and app layout
- Integrates web authentication routes into the initialization process
Reviewed Changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
stubs/controllers/LoginController.php | New authentication controller with redirect to telescope |
stubs/views/login.blade.php | Bootstrap-styled login form template |
stubs/views/app.blade.php | Base application layout template |
src/ProjectInitializatorServiceProvider.php | Publisher configuration for web login assets |
src/Commands/InitCommand.php | Integration of web login publishing into init command |
tests/InitCommandTest.php | Test coverage for web login feature |
tests/TestCase.php | Helper method for fixture assertions |
tests/fixtures/InitCommandTest/*.php | Test fixtures for validation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
tests/TestCase.php
Outdated
]; | ||
} | ||
|
||
protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void | |
protected function assertFileEqualsFixture(string $fixture, string $fileName, bool $exportMode = false): void |
tests/TestCase.php
Outdated
protected function assertEqualsFixture(string $fixture, $data, bool $exportMode = false): void | ||
{ | ||
if ($this->globalExportMode || $exportMode) { | ||
$this->exportJson($fixture, $data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$this->exportJson($fixture, $data); | |
$this->exportContent($data, $fixture); |
tests/TestCase.php
Outdated
} | ||
|
||
$fixturePath = $this->prepareFixtureName($this->getFixturePath($fixture)); | ||
$assertFailedMessage = "Failed asserting that the provided data equal to fixture: {$fixturePath}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$assertFailedMessage = "Failed asserting that the provided data equal to fixture: {$fixturePath}"; | |
$assertFailedMessage = "Failed asserting that the file {$fileName} equal to fixture: {$fixturePath}"; |
refs: #38
…8_Add-web-login-feature
fix: revert File class import
refs: #38