[55] additional admins migrations #57

neellii · 2025-09-12T08:37:27Z

No description provided.

refs: #55

coveralls · 2025-09-12T08:51:46Z

Pull Request Test Coverage Report for Build 17669561026

Details

27 of 27 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 98.966%

Totals
Change from base Build 17647802486:	0.1%
Covered Lines:	287
Relevant Lines:	290

💛 - Coveralls

Copilot

Pull Request Overview

This PR adds support for generating additional admin migrations when setting up Laravel projects with Telescope and Nova admin panels. It handles different authentication types (none vs Clerk) and creates appropriate migration files for additional admin users.

Adds logic to track and create admin migrations based on authentication type
Implements separate handling for users table vs admins table depending on auth configuration
Updates test fixtures to validate the new admin migration functionality

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Commands/InitCommand.php	Adds core logic for publishing additional admin migrations with auth type handling
resources/views/users_add_additional_admin.blade.php	Template for adding admin users to users table
resources/views/admins_create_or_add_additional_admin.blade.php	Template for creating/adding to admins table
tests/InitCommandTest.php	Updates tests to validate new admin migration behavior
tests/fixtures/InitCommandTest/*.php	Test fixture files for various admin migration scenarios

Comments suppressed due to low confidence (1)

resources/views/admins_create_or_add_additional_admin.blade.php:1

The down() method attempts to delete a specific admin record after dropping the entire admins table. This will fail because the table no longer exists. The deletion should happen before dropping the table, or the table drop should be conditional on whether this migration created it.

use Illuminate\Database\Migrations\Migration;

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

DenTray · 2025-09-18T09:47:37Z

src/Commands/InitCommand.php

                $defaultPassword = substr(md5(uniqid()), 0, 8);

-                $email = $this->ask("Please enter a {$title}'s admin email", "admin@{$kebabName}.com");
+                $email = $this->ask("Please enter a {$title}'s admin email", "{$key}_admin@{$kebabName}.com");


Suggested change

$email = $this->ask("Please enter a {$title}'s admin email", "{$key}_admin@{$kebabName}.com");

$email = $this->ask("Please enter a {$title}'s admin email", "admin.{$key}@{$kebabName}.com");

DenTray · 2025-09-18T09:55:45Z

src/Commands/InitCommand.php

+                $email = $this->ask("Please enter a {$title}'s admin email", "{$key}_admin@{$kebabName}.com");
                $password = $this->ask("Please enter a {$title}'s admin password", $defaultPassword);
+
+                $this->publishAdditionalAdminMigration($title, $key, $email, $password);


could we use createAdminUser method instead of all else block? It looks it make the same but need to add more arguments to it

DenTray · 2025-09-18T09:58:04Z

src/Commands/InitCommand.php

+                    'email' => $adminEmail,
+                    'password' => $adminPassword,
+                    'credentialName' => $credentialName,
+                    'isAdminsCreated' => $this->isAdminsTableCreated,


may we just check that the $adminCredentials property is not empty instead of storing isAdminsTableCreated field?

DenTray · 2025-09-18T09:58:32Z

resources/views/admins_create_or_add_additional_admin.blade.php

+use Illuminate\Database\Schema\Blueprint;
+@endif
+
+class Add{{ ucfirst($credentialName) }}Admin extends Migration


Suggested change

class Add{{ ucfirst($credentialName) }}Admin extends Migration

class Add{{ ucfirst($serviceName) }}Admin extends Migration

DenTray · 2025-09-18T09:59:08Z

resources/views/admins_create_or_add_additional_admin.blade.php

+
+    public function up(): void
+    {
+        @if (!$isAdminsCreated)


Suggested change

@if (!$isAdminsCreated)

@if (!$needToCreateTable)

DenTray · 2025-09-18T10:02:15Z

resources/views/admins_create_or_add_additional_admin.blade.php

+    public function up(): void
+    {
+        @if (!$isAdminsCreated)
+Schema::create('admins', function (Blueprint $table) {


I believe that we need to publish already exists migration admins_create_table.blade.php in the base command before publish this migration

…mins refs: #55

…or into 55-admins-migrations

refs: #55

DenTray · 2025-09-29T10:47:44Z

src/Commands/InitCommand.php

    }

-    protected function createAdminUser(string $kebabName): void
+    protected function createAdminUser(string $kebabName, string $serviceName = '', string $adminPrefix = 'an'): array


Suggested change

protected function createAdminUser(string $kebabName, string $serviceName = '', string $adminPrefix = 'an'): array

protected function createAdminUser(string $kebabName, string $serviceKey = '', string $serviceName = ''): array

DenTray · 2025-09-29T10:49:17Z

src/Commands/InitCommand.php

-    protected function createAdminUser(string $kebabName): void
+    protected function createAdminUser(string $kebabName, string $serviceName = '', string $adminPrefix = 'an'): array
    {
+        $adminEmail = $serviceName ? "admin.{$serviceName}@{$kebabName}.com" : "admin@{$kebabName}.com";


Suggested change

$adminEmail = $serviceName ? "admin.{$serviceName}@{$kebabName}.com" : "admin@{$kebabName}.com";

$adminEmail = when($serviceName, "admin.{$serviceName}@{$kebabName}.com", "admin@{$kebabName}.com");

DenTray · 2025-09-29T10:50:20Z

src/Commands/InitCommand.php

-            'email' => $this->ask('Please enter an admin email', "admin@{$kebabName}.com"),
-            'password' => $this->ask('Please enter an admin password', $defaultPassword),
+        $adminCredentials = [
+            'email' => $this->ask("Please enter {$adminPrefix} admin email", $adminEmail),


Suggested change

'email' => $this->ask("Please enter {$adminPrefix} admin email", $adminEmail),

'email' => $this->ask("Please enter admin email for {$serviceName}", $adminEmail),

DenTray · 2025-09-29T10:51:57Z

src/Commands/InitCommand.php

-            if (!empty($this->adminCredentials) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {
-                $email = $this->adminCredentials['email'];
-                $password = $this->adminCredentials['password'];
+            if (isset($this->adminCredentials['email']) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {


Suggested change

if (isset($this->adminCredentials['email']) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {

if (!empty($this->adminCredentials) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {

DenTray · 2025-09-29T10:52:28Z

src/Commands/InitCommand.php

+                $adminCredentials['email'] = $this->adminCredentials['email'];
+                $adminCredentials['password'] = $this->adminCredentials['password'];


Suggested change

$adminCredentials['email'] = $this->adminCredentials['email'];

$adminCredentials['password'] = $this->adminCredentials['password'];

$adminCredentials = $this->adminCredentials;

DenTray · 2025-09-29T11:05:49Z

src/Commands/InitCommand.php

+
+                $adminCredentials['migrationName'] = Str::studly($migrationName);
+            } else {
+                $viewName = $migrationName = 'admins_create_table';


not sure that such view is exists. Anyway, let's pusblish migration for the admins table creation outside of this method just after we decided that need to create user with the cleark auth

Ni Nelli added 5 commits September 10, 2025 13:46

feat: migrate additional admins to database

df4924e

refs: #55

fix: fix additional admins migrations

b8a9963

refs: #55

refactor: migrate admins by auth type, add tests

2651b37

refs: #55

fix: fix migration's classname redefined error

f52446e

refs: #55

chore: merge with main

e8338dd

refs: #55

neellii assigned DenTray Sep 15, 2025

DenTray requested a review from Copilot September 18, 2025 09:16

Copilot AI reviewed Sep 18, 2025

View reviewed changes

DenTray requested changes Sep 18, 2025

View reviewed changes

DenTray assigned neellii and unassigned DenTray Sep 18, 2025

Ni Nelli added 3 commits September 26, 2025 11:33

refactor: use existing createAdminUser method to create additional ad…

fb258ec

…mins refs: #55

Merge branch 'main' of github.com:RonasIT/laravel-project-initializat…

54358a9

…or into 55-admins-migrations

test: fix tests

73cc686

refs: #55

neellii assigned DenTray and unassigned neellii Sep 26, 2025

DenTray requested changes Sep 29, 2025

View reviewed changes

DenTray assigned neellii and unassigned DenTray Sep 29, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[55] additional admins migrations #57

[55] additional admins migrations #57

Uh oh!

neellii commented Sep 12, 2025

Uh oh!

coveralls commented Sep 12, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 18, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

DenTray Sep 29, 2025

Uh oh!

Uh oh!

	$email = $this->ask("Please enter a {$title}'s admin email", "{$key}_admin@{$kebabName}.com");
	$email = $this->ask("Please enter a {$title}'s admin email", "admin.{$key}@{$kebabName}.com");

	class Add{{ ucfirst($credentialName) }}Admin extends Migration
	class Add{{ ucfirst($serviceName) }}Admin extends Migration

	protected function createAdminUser(string $kebabName, string $serviceName = '', string $adminPrefix = 'an'): array
	protected function createAdminUser(string $kebabName, string $serviceKey = '', string $serviceName = ''): array

	$adminEmail = $serviceName ? "admin.{$serviceName}@{$kebabName}.com" : "admin@{$kebabName}.com";
	$adminEmail = when($serviceName, "admin.{$serviceName}@{$kebabName}.com", "admin@{$kebabName}.com");

	'email' => $this->ask("Please enter {$adminPrefix} admin email", $adminEmail),
	'email' => $this->ask("Please enter admin email for {$serviceName}", $adminEmail),

	if (isset($this->adminCredentials['email']) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {
	if (!empty($this->adminCredentials) && $this->confirm("Is {$title}'s admin the same as default one?", true)) {

		$adminCredentials['email'] = $this->adminCredentials['email'];
		$adminCredentials['password'] = $this->adminCredentials['password'];

	$adminCredentials['email'] = $this->adminCredentials['email'];
	$adminCredentials['password'] = $this->adminCredentials['password'];
	$adminCredentials = $this->adminCredentials;

[55] additional admins migrations #57

Are you sure you want to change the base?

[55] additional admins migrations #57

Uh oh!

Conversation

neellii commented Sep 12, 2025

Uh oh!

coveralls commented Sep 12, 2025

Pull Request Test Coverage Report for Build 17669561026

Details

💛 - Coveralls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!