fix: Restore focus ring for VSCodeButton component #2572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Resolves #2571
This PR fixes the main action buttons (like "Start New Task", "Resume Task", "Terminate", and other buttons) that did not show a visual focus outline when navigated to using the keyboard.
This style was added in this commit during the initial implementation of
WelcomeView
andSettingsView
:8ba1be1
This style was added very early in the claude-dev project, and I think it's no longer necessary (though this may be a matter of preference).
I'm adding a screenshot of the current WelcomeView. Perhaps it would be good to have rings around the buttons?
Related Issue
There are no other issues about button focus styles besides the one this PR resolves.
This fix supports usability improvements like the focus shortcuts added in #2369, making it easier to reliably move focus to these buttons.
Implementation
This PR removes the following style:
https://github.com/RooVetGit/Roo-Code/blob/8bb3839b4d5b52803c97941e316a51d402bc6556/webview-ui/src/index.css#L186-L188
This allows the default focus ring to appear on
VSCodeButton
components.Screenshots
2025-04-13.22.19.56.mov
2025-04-13.22.18.28.mov
How to Test
Shift+Tab
repeatedly. Focus should cycle through the action buttons above the textarea.Tab
andShift+Tab
to navigate other elements and confirm the focus ring appears on the buttons when they are focused.Get in Touch
Important
Restores focus ring for
VSCodeButton
components to improve keyboard navigation by removing a CSS rule inindex.css
.VSCodeButton
components by removingoutline: none;
style inindex.css
.Tab
andShift+Tab
in the Roo extension panel.This description was created by
for 8a87f8c. It will automatically update as commits are pushed.