Skip to content

Conversation

pokutuna
Copy link

@pokutuna pokutuna commented Apr 13, 2025

Context

Resolves #2571

This PR fixes the main action buttons (like "Start New Task", "Resume Task", "Terminate", and other buttons) that did not show a visual focus outline when navigated to using the keyboard.

This style was added in this commit during the initial implementation of WelcomeView and SettingsView:
8ba1be1

This style was added very early in the claude-dev project, and I think it's no longer necessary (though this may be a matter of preference).
I'm adding a screenshot of the current WelcomeView. Perhaps it would be good to have rings around the buttons?

スクリーンショット 2025-04-14 1 52 23

Related Issue

There are no other issues about button focus styles besides the one this PR resolves.

This fix supports usability improvements like the focus shortcuts added in #2369, making it easier to reliably move focus to these buttons.

Implementation

This PR removes the following style:

https://github.com/RooVetGit/Roo-Code/blob/8bb3839b4d5b52803c97941e316a51d402bc6556/webview-ui/src/index.css#L186-L188

This allows the default focus ring to appear on VSCodeButton components.

Screenshots

before after
2025-04-13.22.19.56.mov
2025-04-13.22.18.28.mov

How to Test

  1. Run this PR's version of the Roo extension.
  2. Open the Roo view/panel in VS Code.
  3. Click the chat input text area.
  4. Press Shift+Tab repeatedly. Focus should cycle through the action buttons above the textarea.
  5. When a button has focus, it should now display the focus outline provided by VS Code.
  6. Use Tab and Shift+Tab to navigate other elements and confirm the focus ring appears on the buttons when they are focused.

Get in Touch


Important

Restores focus ring for VSCodeButton components to improve keyboard navigation by removing a CSS rule in index.css.

  • Behavior:
    • Restores focus ring for VSCodeButton components by removing outline: none; style in index.css.
    • Improves keyboard navigation for action buttons like "Start New Task", "Resume Task", etc.
  • Testing:
    • Focus ring now appears when navigating buttons using Tab and Shift+Tab in the Roo extension panel.

This description was created by Ellipsis for 8a87f8c. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Apr 13, 2025

⚠️ No Changeset found

Latest commit: 8a87f8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 13, 2025
@mrubens mrubens merged commit caf1ae3 into RooCodeInc:main Apr 13, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 13, 2025
Yikai-Liao pushed a commit to Yikai-Liao/Roo-Code that referenced this pull request Apr 16, 2025
daniel-lxs pushed a commit to daniel-lxs/Roo-Code that referenced this pull request Apr 22, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request May 6, 2025
* Add disk.ts and move out ensureTaskDirectoryExists

* refactor: move disk operations out of Task

* Move prompts out of Task

* Remove legacy tool_use conversion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus ring missing on main buttons for keyboard navigation
3 participants