fix: checkpoint restore popover positioning issue (#8219) #8220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
Fixes issue where the checkpoint restore popover would misposition when the mouse moved from the CheckpointSaved component to the popover itself. The menu now remains visible while the popover is open, preventing the anchor element from disappearing. Fixes #8219
dosubot
bot
added
size:S
hannesrudolph
added
the
Issue/PR - Triage
| export const CheckpointSaved = ({ checkpoint, ...props }: CheckpointSavedProps) => { | ||
| const { t } = useTranslation() | ||
| const isCurrent = props.currentHash === props.commitHash | ||
| const [isPopoverOpen, setIsPopoverOpen] = useState(false) |
There was a problem hiding this comment.
Missing test coverage: Consider adding tests for this component, especially to verify the popover positioning fix and state management behavior. This would help prevent regression of the positioning bug.
| onOpenChange={(open) => { | ||
| setIsOpen(open) | ||
| setIsConfirming(false) | ||
| onPopoverOpenChange?.(open) |
There was a problem hiding this comment.
Potential optimization: While the current implementation works well, consider memoizing the callback in the parent component if this component gets re-rendered frequently to avoid unnecessary re-renders.
|
|
||
| <div className="hidden group-hover:block h-4 -mt-2"> | ||
| <CheckpointMenu {...props} checkpoint={metadata} /> | ||
| <div className={`h-4 -mt-2 ${isPopoverOpen ? "block" : "hidden group-hover:block"}`}> |
There was a problem hiding this comment.
Minor suggestion: For better semantic clarity, consider using a data attribute approach like instead of the ternary operator for class toggling. This would make the intent more explicit:
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
… add focused test for visibility logic (#8220)
dosubot
bot
added
size:L
…heckpointSaved component
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Needs Review]
in Roo Code Roadmap
mrubens
approved these changes
Sep 23, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the checkpoint restore popover positioning issue where the popover would misplace when the mouse moved from the CheckpointSaved component to the popover itself.
Problem
The CheckpointMenu was only visible on hover (using
hidden group-hover:block). When users moved their mouse to interact with the popover, they would leave the hover area of the parent group, causing the CheckpointMenu to hide and the popover to lose its anchor element, resulting in incorrect positioning.Solution
Added state tracking to maintain menu visibility when the popover is open:
isPopoverOpenstate in CheckpointSaved componentonPopoverOpenChangecallback prop to CheckpointMenuChanges
Testing
Fixes #8219
Important
Fixes popover positioning in
CheckpointSavedby managing menu visibility with new state and callback, ensuring correct interaction behavior.CheckpointSavedby maintaining menu visibility when popover is open.isPopoverOpenstate andonPopoverOpenChangecallback inCheckpointSaved.CheckpointMenuto handle controlled and uncontrolled popover states.CheckpointSaved.spec.tsxto test popover visibility and confirm state reset.CheckpointMenuto useopenandonOpenChangeprops for popover control.This description was created by
for 51059b9. You can customize this summary. It will automatically update as commits are pushed.