fix(context): truncate type definition to match max read line #8509
+540
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #8149
Roo Code Task Context (Optional
Description
This PR adds the ability to truncate the
list_code_definition_names
to match the maximum line that can be read. Previously, only theread_file
tool call that applies this limit. Sincelist_code_definition_names
come from the file, it should also respect that setting. Otherwise we might pollute the context and exceeds the context window limit.Test Procedure
Pre-Submission Checklist
Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
@elianiva
Important
Add truncation of code definitions to respect
maxReadFileLine
inlistCodeDefinitionNamesTool
andreadFileTool
.listCodeDefinitionNamesTool
inlistCodeDefinitionNamesTool.ts
now truncates code definitions based onmaxReadFileLine
setting.readFileTool
inreadFileTool.ts
applies truncation to code definitions when reading files exceeding line limits.truncateDefinitionsToLineLimit
intruncateDefinitions.ts
to handle truncation logic.truncateDefinitionsToLineLimit
intruncateDefinitions.spec.ts
.listCodeDefinitionNamesTool
inlistCodeDefinitionNamesTool.spec.ts
to verify truncation behavior.This description was created by
for e6de349. You can customize this summary. It will automatically update as commits are pushed.