Skip to content

RK-7317 - Change ' to " in sh command #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2020
Merged

RK-7317 - Change ' to " in sh command #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f841e98
Change ' to " in sh command
yuval-shavit Oct 13, 2020
ad7de38
escaping dollars
ElDuderinos Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .jenkins/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,6 @@ import org.rookout.testsUtil.TestUtilities

def label = "worker-${UUID.randomUUID().toString()}"

static def getDockerTagNameForRegression(testType, jobName) {
return "us.gcr.io/rookout/${testType}-${jobName}:latest"
}

podCreator.initMain(label: label) {
node(label) {
print(pwd())
Expand All @@ -18,8 +14,8 @@ podCreator.initMain(label: label) {
def scriptToUse = libraryResource 'generate_tests.groovy'
def jobName = "tutorial-python"
def testType = "regression-test"
def dockerTag = getDockerTagNameForRegression(testType, jobName)
sh('docker build . -t ${dockerTag} --build-arg GIT_COMMIT=$(git rev-parse HEAD) --build-arg GIT_ORIGIN=$(git config --get remote.origin.url) && gcloud docker -- push ${dockerTag}')
def dockerTag = TestUtilities.getDockerTagNameForRegression(jobName)
sh("docker build . -t ${dockerTag} --build-arg GIT_COMMIT=\$(git rev-parse HEAD) --build-arg GIT_ORIGIN=\$(git config --get remote.origin.url) && gcloud docker -- push ${dockerTag}")
TestUtilities.createTest(this, scriptToUse, jobName, pwd() + "/.jenkins", "Jenkinsfile.test")
stage ('Run the tests') {
def rookoutVersionInFile = sh(script: "cat ${pwd()}/requirements.txt | grep 'rook' | cut -d '=' -f 2", returnStdout: true)
Expand Down