Characters PLOD

[mina-kleid]

More documentation for the following character PLOD would be great

• Get characters PLOD by :algorithm . which algorithms are available and what should i provide in the request for each algorithm also are they going to be sorted ?
• Get character PLOD values, limited by :count parameter , are they going to be sorted ? if yes Ascending or descending ?
• https://api.got.show/api/plod/find , how should be the request format? is it in the body or in the header like the character find ?

also currently all PLOD requests doesnt return anything

[Legenzoo]

@togiberlin Haven´t you implemented this?

[sacdallago]

There's actually no way to populate the PLOD collection. No NPM script, nor I see the collection on the db.

I NEED full hands on this issue, now.

@kordianbruck @Adiolis @togiberlin @boriside

[sacdallago]

You don't even have the dependency in the package.json?!?!!!!

What the fuck guys, who was responsible for this?????

[sacdallago]

@TheZoker @AlexMoroz @alschm

[Legenzoo]

Sorry, i can´t really help here, because i am not aware of the things that have been done according the PLOD. I am only as up-to-date as the issue #101.

I also see no possibility to fill the db by scraper or data json. So probably another group used the api @togiberlin implemented to fill the data?

I know that there has been some Plod data on @kordianbruck ´s server.

[sacdallago]

@Adiolis that might have been mock data, because one quick look at the repos of B illuminates us all:

1. https://github.com/Rostlab/JS16_ProjectB_Group6/blob/develop/main.js that can be imported and called with the character name and the PLOD stored in the relevant collection
2. https://github.com/Rostlab/JS16_ProjectB_Group7/blob/develop/npm.js same thing.

Literally: Import package, for every character get the prediction via the relevant function in the package, store it in the DB.

[sacdallago]

Actually, let me be even more specific:

1. https://github.com/Rostlab/JS16_ProjectB_Group6/blob/develop/main.js#L16
2. https://github.com/Rostlab/JS16_ProjectB_Group7/blob/develop/npm.js#L59

Don't get me wrong, I know you were not responsible for this. I know who was responsible for this. @TheZoker @togiberlin ( in part @CavidSalahov @AlexMoroz )

EDIT I know my chickens

[Legenzoo]

I notified the group on facebook. I can´t do that before Thursday. =/

[TheZoker]

@sacdallago Which dependency is missing in the package.json? I don't fully understand what's going on right now
Do you mean the hole package of project B? https://www.npmjs.com/package/gotplod

[sacdallago]

@TheZoker https://github.com/Rostlab/JS16_ProjectA/blob/master/package.json#L20
There should be the two packages from B somewhere here, and someone in A should be using them to generate the PLODs

[TheZoker]

These are the missing dependencies, right?

[sacdallago]

Step one.

[TheZoker]

Am I responsible for anything else here?

[AlexMoroz]

@TheZoker use "latest" for package versions

[sacdallago]

@TheZoker no. thanks
but yes, @AlexMoroz is right

[TheZoker]

@AlexMoroz Like "gotarffplod": "latest"?

[AlexMoroz]

yes

[TheZoker]

Done.

[sacdallago]

I'm still unhappily waiting.

[Legenzoo]

I tried to have a look into the package, but node gives me:

Error: Cannot find module 'gotplod'

I have started npm install with the new package.json and also npm install gotplod.
Using the online test tool of npm gives me the same result:
https://tonicdev.com/npm/gotplod

Error: Cannot find module 'gotplod' Error Viewer
Whoops, should we have 'gotplod'?
We should have every package on npm. Sometimes this error is caused by a typo in your require path, but if you think we are actually missing this package, please confirm below and we’ll do our best to fix it as soon as possible!

@TheZoker @AlexMoroz

Edit: The files are in node_modules. Don´t get the problem with require...

[jsalahov]

@Adiolis Fixed the problem with 'gotplod'. Download the new version.

[AlexMoroz]

@Adiolis try also gotarffplod

[sacdallago]

No. The packe was not deployed to npm

[AlexMoroz]

Package deployed.

[sacdallago]

Ok, I've updated the thing but now comes another observation:

why is there an imbalance towards the number of predicted characters with one alg and with the otherone? Is this wanted @goldbergtatyana ?

Look at the output of the call: https://api.got.show/api/plod/

If I filter by gotplod I get 1946 hits, if I filter per gotarffplod I get 174.

[Legenzoo]

@sacdallago Jep, i have noticed many characters with Plod unknown. I skipped them.

[sacdallago]

Thx @Adiolis , let's wait for the answer of @nicoladesocio @goldbergtatyana or anyone involved in the gotarffplod.

It might as well be design, but it's good to know also for @Mina-Zaki who has to implement this in the froentend

[goldbergtatyana]

@sacdallago @Adiolis very well spotted! this should absolutely not be. The number of characters predicted by Group 6 (gotplod) is 1946 - which is correct, while the number of characters predicted by Group 7 (gotarffplod) is 1939 - this number is wrong.

[sacdallago]

@nicoladesocio @konstantinos-angelo @dan736923 @AlexMoroz fix?

[goldbergtatyana]

@s-feng apparently wrong prediction results got delivered to Group A. Can you please talk to @nicoladesocio @konstantinos-angelo @dan736923 @AlexMoroz to fix it by providing results of test 5? Thanks so much!

[dan736923]

@goldbergtatyana This is because I removed some characters with invalid dateOfBirth/Death attributes (e.g. 298299) in test5. (Which also would have messed up age attribute) If you think it is useful, I can make another run including those characters and upload new JSON files.

[AlexMoroz]

@dan736923 but now only 174 characters have plod

[goldbergtatyana]

thanks @AlexMoroz for running the test.

@dan736923 but you used all of these features for the prediction of plods for 1939 characters. so, yeah, we do need plod predictions for all of them!

[TheZoker]

@AlexMoroz Do you need help with anything?

[Legenzoo]

@sacdallago This is no issue anymore for Project A, isn´t it? The filling of Plods and the API works.
I would close this here and well, open an issue on the other project, because to less data is provided.

[AlexMoroz]

@TheZoker no,we've fixed it, thanks

[AlexMoroz]

gotarffplod@0.0.5 with new predictions is published

[sacdallago]

Niiiice

[Legenzoo]

@sacdallago

[sacdallago]

yeah yeah @Adiolis later, gotta run now :D

[Legenzoo]

You are not angry anymore, aren´t you? 😆

[sacdallago]

nope, I'm just behind on work... Now it's done.