Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Added tum bar at top 2.0 #494

Merged
merged 4 commits into from
Apr 24, 2016
Merged

Added tum bar at top 2.0 #494

merged 4 commits into from
Apr 24, 2016

Conversation

yashha
Copy link
Collaborator

@yashha yashha commented Apr 23, 2016

Well, hm
image

@sacdallago
Copy link
Contributor

Very nice @yashha
Last thing I would like to try out is: use the dark color-scheme, similar to the one I put on the comment using the colors of the corporate design

Maybe also @jorjo1 and/or @mammuth can help?

Again: thank you! This looks exactly like they want to have it.

@goldbergtatyana
Copy link
Collaborator

All, since we're working on the front page, can we please have the rostlab logo centered in the footer? Thanks!

@jorjo1
Copy link
Contributor

jorjo1 commented Apr 23, 2016

@sacdallago @goldbergtatyana Should TUM logo be this big?

@gyachdav
Copy link
Collaborator

No merging until I say so. This issue is now on hold until further notice.

@yashha
Copy link
Collaborator Author

yashha commented Apr 23, 2016

I think the map page has to be adjusted, before merge.

Am 23. Apr. 2016, 13:38, um 13:38, Georgi Anastasov notifications@github.com schrieb:

Should TUM logo be this big?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#494 (comment)

@mammuth
Copy link
Collaborator

mammuth commented Apr 23, 2016

Not only the map. You need to higher the main containers padding with the
height of the new tum-bar.

On Sat, Apr 23, 2016, 13:46 yashha notifications@github.com wrote:

I think the map page has to be adjusted, before merge.

Am 23. Apr. 2016, 13:38, um 13:38, Georgi Anastasov <
notifications@github.com> schrieb:

Should TUM logo be this big?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#494 (comment)


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#494 (comment)

@sacdallago
Copy link
Contributor

Me @gyachdav and @goldbergtatyana just talked and again the idea is:

You can go on working, this is not on hold anymore :P

The above are official colors for both background and text, which can be found here https://portal.mytum.de/pressestelle/tum_mit/2007nr2/09.pdf on the third page, the third set of colors on the right.

You can find all the logos and specification of the corporate design here:
https://portal.mytum.de/corporatedesign/index_html by accessing with your TUM credentials

Apart from that, please work on the other fixes that @mammuth and @yashha talked about.

@jorjo1 The size is "imposed" by the logo and corporate design. I know this is annoying as fuck but again: better do it right then having them tell us to re-do it for the fourth time now.

Please, like you always do, send us screenshots when you have something to show and thank you again :)

@sacdallago
Copy link
Contributor

Hi guys,
anything on this regard? We got another email from the legal office asking if we "accepted their conditions" :P :P

@gyachdav
Copy link
Collaborator

Rephrasing what @sacdallago just said - we need this done ASAP. Should be up live within the hour. Whoever is I front of a laptop please take care now.

This coming from the president of the university!

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

I don't have access to any of the guidlines on https://portal.mytum.de/corporatedesign/index_html.
Are they important?

@sacdallago
Do you want this on the top of the page?
https://cloud.githubusercontent.com/assets/6240943/14739285/e3c168da-0886-11e6-8a10-7e4f63884d92.jpg

@sacdallago
Copy link
Contributor

sacdallago commented Apr 24, 2016

Yes please @yashha I can give you the pngs and color for the background, hold on

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

Why not the svgs, I am currently using?

@sacdallago
Copy link
Contributor

sacdallago commented Apr 24, 2016

Official white TUM logo:
tum_logo_weiss_rgb_p

It's white... :D so you probably won't see it here :D :D :D :D just click on it, open it, and download it

@sacdallago
Copy link
Contributor

sacdallago commented Apr 24, 2016

Color scheme:

  1. 353535 --> https://www.colorcodehex.com/353535/
  2. 828282 --> https://www.colorcodehex.com/828282/
  3. cecece --> https://www.colorcodehex.com/cecece/

I would say 353535 for background! You should use the same background color for the rest of the page (I have tried to inspect the page and change the body { background: #1f1f1f; ..} to body { background: #353535; ..} and you can barely see the difference!

Edit: It looks terrible on the rankings page. Just keep the two different backgrounds and send us a screenshot please.. Should not look that bad

Thanks

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

Its a bit brighter than before:
image

@sacdallago
Copy link
Contributor

Good @yashha we are almost there. How about keeping the body color the same? Screenshot of that please?

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

image
Is there no darker color provided by tum?

@sacdallago
Copy link
Contributor

Unfortunately not 😢

I would keep this last one, @gyachdav I need your ok and @goldbergtatyana as well

@gyachdav
Copy link
Collaborator

Green light to merge from me and I okay for @goldbergtatyana too

dont wait with the merge please.

@sacdallago
Copy link
Contributor

Ok than please @yashha commit your last work and I will close this :)

Thank you soso much

@sacdallago sacdallago self-assigned this Apr 24, 2016
@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

Now I still have to fix some spacings, because of the new bar at the top we have to adjust the spacings of many pages.

@sacdallago
Copy link
Contributor

Ping me when it's time to review and merge :)

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

It's done. :)
@sacdallago I don't know, maybe @jorjo1 or @mammuth check if every spacing is fixed
Or we deploy it and fix it with an quickfix afterwards

@gyachdav
Copy link
Collaborator

In merging. Chris deploy ASAP.

All please go over and prepare hotfixes. We need this done ASAP.

@gyachdav gyachdav merged commit 31e9027 into develop Apr 24, 2016
@gyachdav
Copy link
Collaborator

@yashha put in the following changes:

TUMLogoWritten{ margin-top:: 50px;}
TUMLogo{ remove margin-top or margin-top:0px;}

please modify asap.

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

So a smaller bar? @gyachdav
image

@gyachdav
Copy link
Collaborator

yes way way shorter. please check on mobile, i only checked with dev tools that this works on desktops

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

image
s5:
image

@yashha
Copy link
Collaborator Author

yashha commented Apr 24, 2016

shell I make it short like on mobile on desktop too?

@gyachdav
Copy link
Collaborator

Yes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants