Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bye bye develop #126

merged 73 commits into from Nov 7, 2019


Copy link

paulfalgout commented Nov 7, 2019

No description provided.

paulfalgout and others added 30 commits Oct 21, 2019
`itemTemplateContext` should be `_.result` doesn't fix anything current
`.is-selected` is always on the child of the `li`
Also changes the main nav to a droplist to keep current selection.
Add navigation switching

Add program sidebar
throws in a half done sidebar for free because I misread the cards 🙍

Adds program layout + context trail
Add program errors
Also updated some styles that were conflicting
Move program sidebar view

Adds read only sidebar/context menu for triggering edit
So some things were nested `admin/programs/program`
But just having `admin/program/` aligns with `patients/patient`
Reorg admin things like patient
- Cypress tests weren't using utc in data
- patient tab wasn't block, so without a button would collapse
- routes with single routes were an array
- patient_app was passing unused info to child apps.
In some cases moving an element within fill window caused scrollbars.
Add program actions
Even though the date is in data, it comes from a datepicker so the value will be the day in local time and not utc
Update dependencies
BenCoffeed and others added 27 commits Nov 1, 2019
Update preview deploys to use fe/ directory

Adds new Add Action button to dashboard

This should avoid returning to alternate URLs on a logout.  Similarly it updates the auth0-spa-js in hopes of solving the cookie issue we may or may not be seeing.
Update auth0 and logout returnTo
This allows a simpler pattern
This greatly reduces the complexity of what will be a common use case.  However it means
beforeStart() {
  return [1,2,3];
onStart(options, one, two, three)
where as before it would have been `onStart(options, array)`
3.6.0 fixes the issues seen in 3.5

The test modification is because previously we had a lazy test that got away with some ids not linking up, but returning the instance makes this a bit more strict in our id alignment in testing.

Refactor/simplify fetch patterns

Fetch program along with action activity for sidebar

Pick only relevant form fields when saving program
We're using so many url options that it is the primary url that should be registered. Also we're no longer using success, which isn't a problem because 100% of the usage of this had it anyhow.
Also updates bootstrap to use `beforeStart`
The program action filter wasn't correct and we can use the url on the collection
When we require parallel calls we can new route creation.
In some cases we can use returning includes to cheat relationships that would otherwise be nearly impossible to maintain.
Chore/parallel requests

Uses program action status enum instead of published bool

Trim program, program-action, and action names in validation
@paulfalgout paulfalgout merged commit 1912cf7 into master Nov 7, 2019
5 checks passed
5 checks passed
Automated Preview AWS pull request preview
codecov/patch 100% of diff hit (target 94.58%)
codecov/project 98.26% (+3.68%) compared to 40e1103
cypress: care ops 61 tests passed in 00:59
test-deploy Workflow: test-deploy
@paulfalgout paulfalgout deleted the develop branch Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
4 participants
You can’t perform that action at this time.